MD Settings: Remove double highlight from paper-checkbox in language menu.

MD Settings: Remove double highlight from paper-checkbox in language menu.

BUG=664032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e2ab808cb9b87af6fb77cd6c82cb3da3bd63208e
Cr-Commit-Position: refs/heads/master@{#431385}

[dpapad, 2016-11-10 19:30:12]

Description was changed from

==========
MD Settings: Remove double highlight from paper-checkbox in language menu.

BUG=664032
==========

to

==========
MD Settings: Remove double highlight from paper-checkbox in language menu.

BUG=664032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-11-10 19:38:37]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-11-10 19:38:37]

Before screenshot http://imgur.com/a/n2o7o. This regressed at
https://codereview.chromium.org/2489723002 which tweaked action menu to match
the mocks.

https://codereview.chromium.org/2494803002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/2494803002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:64:
#offerTranslations:focus {
Need to use id to override the specificity of
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_action....
I am not putting a paper-checkbox CSS rule inside cr_action_menu.html, since I
think this menu is the only one using a checkbox.

[Dan Beam, 2016-11-10 20:28:47]

i was going to consider telling to you do the opposite: drop the ripple

either way lgtm, I don't really care THAT much

https://codereview.chromium.org/2494803002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/2494803002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:64:
#offerTranslations:focus {
On 2016/11/10 19:38:37, dpapad wrote:
> Need to use id to override the specificity of
>
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_action....
> I am not putting a paper-checkbox CSS rule inside cr_action_menu.html, since I
> think this menu is the only one using a checkbox.

Acknowledged.

[dpapad, 2016-11-10 21:24:22]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:24:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 22:42:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-10 23:10:30]

Description was changed from

==========
MD Settings: Remove double highlight from paper-checkbox in language menu.

BUG=664032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove double highlight from paper-checkbox in language menu.

BUG=664032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e2ab808cb9b87af6fb77cd6c82cb3da3bd63208e
Cr-Commit-Position: refs/heads/master@{#431385}
==========

[commit-bot: I haz the power, 2016-11-10 23:10:31]

Patchset 1 (id:??) landed as
https://crrev.com/e2ab808cb9b87af6fb77cd6c82cb3da3bd63208e
Cr-Commit-Position: refs/heads/master@{#431385}