Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2494803002: MD Settings: Remove double highlight from paper-checkbox in language menu. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/assert.html"> 1 <link rel="import" href="chrome://resources/html/assert.html">
2 <link rel="import" href="chrome://resources/html/cr.html"> 2 <link rel="import" href="chrome://resources/html/cr.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
8 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 8 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
9 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html"> 9 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">
10 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html"> 10 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html">
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 border: none; 52 border: none;
53 /* TODO(michaelpg): Update to whatever variable is used for the darker, 53 /* TODO(michaelpg): Update to whatever variable is used for the darker,
54 * full-width separators: crbug.com/649547. */ 54 * full-width separators: crbug.com/649547. */
55 border-top: var(--settings-separator-line); 55 border-top: var(--settings-separator-line);
56 margin: 6px 0 0 0; 56 margin: 6px 0 0 0;
57 } 57 }
58 58
59 paper-checkbox.dropdown-item { 59 paper-checkbox.dropdown-item {
60 --checkbox-margin-start: 0; 60 --checkbox-margin-start: 0;
61 } 61 }
62
63 #uiLanguageItem:focus,
64 #offerTranslations:focus {
dpapad 2016/11/10 19:38:37 Need to use id to override the specificity of http
Dan Beam 2016/11/10 20:28:47 Acknowledged.
65 background-color: transparent;
66 }
62 </style> 67 </style>
63 <settings-languages languages="{{languages}}" prefs="{{prefs}}" 68 <settings-languages languages="{{languages}}" prefs="{{prefs}}"
64 language-helper="{{languageHelper}}"> 69 language-helper="{{languageHelper}}">
65 </settings-languages> 70 </settings-languages>
66 <settings-animated-pages id="pages" section="languages"> 71 <settings-animated-pages id="pages" section="languages">
67 <neon-animatable route-path="default"> 72 <neon-animatable route-path="default">
68 <div class="settings-box first two-line"> 73 <div class="settings-box first two-line">
69 <div class="start"> 74 <div class="start">
70 <div>$i18n{languagesListTitle}</div> 75 <div>$i18n{languagesListTitle}</div>
71 <div class="secondary"> 76 <div class="secondary">
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 <paper-checkbox id="uiLanguageItem" class="dropdown-item" 204 <paper-checkbox id="uiLanguageItem" class="dropdown-item"
200 checked="[[isProspectiveUILanguage_( 205 checked="[[isProspectiveUILanguage_(
201 detailLanguage_.language.code, 206 detailLanguage_.language.code,
202 prefs.intl.app_locale.value)]]" 207 prefs.intl.app_locale.value)]]"
203 on-change="onUILanguageChange_" 208 on-change="onUILanguageChange_"
204 disabled="[[disableUILanguageCheckbox_( 209 disabled="[[disableUILanguageCheckbox_(
205 detailLanguage_, prefs.intl.app_locale.value)]]"> 210 detailLanguage_, prefs.intl.app_locale.value)]]">
206 $i18n{displayInThisLanguage} 211 $i18n{displayInThisLanguage}
207 </paper-checkbox> 212 </paper-checkbox>
208 </if> 213 </if>
209 <paper-checkbox class="dropdown-item" 214 <paper-checkbox id="offerTranslations" class="dropdown-item"
210 checked="[[detailLanguage_.translateEnabled]]" 215 checked="[[detailLanguage_.translateEnabled]]"
211 on-change="onTranslateCheckboxChange_" 216 on-change="onTranslateCheckboxChange_"
212 hidden="[[!prefs.translate.enabled.value]]" 217 hidden="[[!prefs.translate.enabled.value]]"
213 disabled="[[disableTranslateCheckbox_( 218 disabled="[[disableTranslateCheckbox_(
214 detailLanguage_.language, languages.translateTarget)]]"> 219 detailLanguage_.language, languages.translateTarget)]]">
215 $i18n{offerToTranslateInThisLanguage} 220 $i18n{offerToTranslateInThisLanguage}
216 </paper-checkbox> 221 </paper-checkbox>
217 <hr> 222 <hr>
218 <button class="dropdown-item" role="menuitem" 223 <button class="dropdown-item" role="menuitem"
219 on-tap="onMoveToTopTap_" 224 on-tap="onMoveToTopTap_"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 </if> 268 </if>
264 </settings-animated-pages> 269 </settings-animated-pages>
265 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp> 270 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp>
266 <settings-add-languages-dialog languages="{{languages}}" 271 <settings-add-languages-dialog languages="{{languages}}"
267 language-helper="[[languageHelper]]"> 272 language-helper="[[languageHelper]]">
268 </settings-add-languages-dialog> 273 </settings-add-languages-dialog>
269 </template> 274 </template>
270 </template> 275 </template>
271 <script src="languages_page.js"></script> 276 <script src="languages_page.js"></script>
272 </dom-module> 277 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698