Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2489723002: MD Settings: Tweak action menu styling to match the mocks. (Closed)

Created:
4 years, 1 month ago by dpapad
Modified:
4 years, 1 month ago
Reviewers:
dschuyler
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Tweak action menu styling to match the mocks. - Adding 8px top/bottom padding. - Adding background-color for focused options. - Removing default focus highlight (outline). BUG=662545 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/66c9c9b813fcc5e538b0b17e28d816a0e7d292fb Cr-Commit-Position: refs/heads/master@{#431077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
dpapad
Screenshots at http://imgur.com/a/WM4DR.
4 years, 1 month ago (2016-11-08 22:27:36 UTC) #3
dpapad
On 2016/11/08 at 22:27:36, dpapad wrote: > Screenshots at http://imgur.com/a/WM4DR. Friendly ping.
4 years, 1 month ago (2016-11-09 21:30:02 UTC) #4
dschuyler
lgtm
4 years, 1 month ago (2016-11-09 21:47:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489723002/1
4 years, 1 month ago (2016-11-09 22:15:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 23:25:56 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 23:27:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66c9c9b813fcc5e538b0b17e28d816a0e7d292fb
Cr-Commit-Position: refs/heads/master@{#431077}

Powered by Google App Engine
This is Rietveld 408576698