Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: xfa/fwl/core/ifwl_comboedit.cpp

Issue 2494743002: IFWL cleanup in the Combo classes (Closed)
Patch Set: Review feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/ifwl_comboedit.h ('k') | xfa/fwl/core/ifwl_combolist.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/ifwl_comboedit.cpp
diff --git a/xfa/fwl/core/ifwl_comboedit.cpp b/xfa/fwl/core/ifwl_comboedit.cpp
index 2a7ac904e155e98dc12b55c94cca2df67f5e83f0..0896ba76df567a286428702434a68f7bbafdda19 100644
--- a/xfa/fwl/core/ifwl_comboedit.cpp
+++ b/xfa/fwl/core/ifwl_comboedit.cpp
@@ -24,12 +24,8 @@ void IFWL_ComboEdit::ClearSelected() {
void IFWL_ComboEdit::SetSelected() {
FlagFocus(true);
- EndCaret();
- AddSelRange(0);
-}
-
-void IFWL_ComboEdit::EndCaret() {
GetTxtEdtEngine()->MoveCaretPos(MC_End);
+ AddSelRange(0);
}
void IFWL_ComboEdit::FlagFocus(bool bSet) {
@@ -41,10 +37,6 @@ void IFWL_ComboEdit::FlagFocus(bool bSet) {
}
}
-void IFWL_ComboEdit::SetComboBoxFocus(bool bSet) {
- m_pOuter->SetFocus(bSet);
-}
-
void IFWL_ComboEdit::OnProcessMessage(CFWL_Message* pMessage) {
if (!pMessage)
return;
@@ -66,7 +58,7 @@ void IFWL_ComboEdit::OnProcessMessage(CFWL_Message* pMessage) {
if ((pMsg->m_dwCmd == FWL_MouseCommand::LeftButtonDown) &&
((m_pProperties->m_dwStates & FWL_WGTSTATE_Focused) == 0)) {
SetSelected();
- SetComboBoxFocus(true);
+ m_pOuter->SetFocus(true);
}
break;
}
« no previous file with comments | « xfa/fwl/core/ifwl_comboedit.h ('k') | xfa/fwl/core/ifwl_combolist.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698