Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: xfa/fwl/core/ifwl_combolist.h

Issue 2494743002: IFWL cleanup in the Combo classes (Closed)
Patch Set: Review feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/ifwl_comboedit.cpp ('k') | xfa/fwl/core/ifwl_listbox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/ifwl_combolist.h
diff --git a/xfa/fwl/core/ifwl_combolist.h b/xfa/fwl/core/ifwl_combolist.h
index 6c380f4f0747b60dd2c0db9ac721edf1125040da..64ffbba6475f1c2a9fbe6ec4bf231cad4d875692 100644
--- a/xfa/fwl/core/ifwl_combolist.h
+++ b/xfa/fwl/core/ifwl_combolist.h
@@ -21,23 +21,24 @@ class IFWL_ComboList : public IFWL_ListBox {
void OnProcessMessage(CFWL_Message* pMessage) override;
int32_t MatchItem(const CFX_WideString& wsMatch);
+
void ChangeSelected(int32_t iSel);
int32_t CountItems();
- void GetItemRect(int32_t nIndex, CFX_RectF& rtItem);
- void ClientToOuter(FX_FLOAT& fx, FX_FLOAT& fy);
- void SetFocus(bool bSet);
-
- bool m_bNotifyOwner;
- friend class IFWL_ComboBox;
+ void SetFocus(bool bSet);
+ void SetNotifyOwner(bool notify) { m_bNotifyOwner = notify; }
private:
+ void GetItemRect(int32_t nIndex, CFX_RectF& rtItem);
+ void ClientToOuter(FX_FLOAT& fx, FX_FLOAT& fy);
void OnDropListFocusChanged(CFWL_Message* pMsg, bool bSet);
int32_t OnDropListMouseMove(CFWL_MsgMouse* pMsg);
int32_t OnDropListLButtonDown(CFWL_MsgMouse* pMsg);
int32_t OnDropListLButtonUp(CFWL_MsgMouse* pMsg);
int32_t OnDropListKey(CFWL_MsgKey* pKey);
void OnDropListKeyDown(CFWL_MsgKey* pKey);
+
+ bool m_bNotifyOwner;
};
#endif // XFA_FWL_CORE_IFWL_COMBOLIST_H_
« no previous file with comments | « xfa/fwl/core/ifwl_comboedit.cpp ('k') | xfa/fwl/core/ifwl_listbox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698