Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2494683004: Revert "Upstream Context.BIND_EXTERNAL_SERVICE" (2/3) (Closed)

Created:
4 years, 1 month ago by Xi Han
Modified:
4 years, 1 month ago
Reviewers:
michaelbai, agrieve, gone, boliu
CC:
chromium-reviews, dominickn+watch_chromium.org, jam, pkotwicz+watch_chromium.org, agrieve+watch_chromium.org, darin-cc_chromium.org, zpeng+watch_chromium.org, android-webview-reviews_chromium.org, Torne, pkotwicz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Upstream Context.BIND_EXTERNAL_SERVICE" This reverts https://codereview.chromium.org/2464143004. We still need the extraflags in the ChildProcessCreationParams to make WebApks work. This CL is depends on https://codereview.chromium.org/2491943003/. BUG=592722, 663898 Committed: https://crrev.com/ce6325156ef6335622e359018f2cd35d98f7693f Cr-Commit-Position: refs/heads/master@{#431580}

Patch Set 1 #

Messages

Total messages: 21 (12 generated)
Xi Han
This is the second one, please take a look, thanks!
4 years, 1 month ago (2016-11-10 19:48:58 UTC) #4
michaelbai
lgtm
4 years, 1 month ago (2016-11-10 19:54:02 UTC) #5
boliu
did the revert have conflicts? if not, rs lgtm
4 years, 1 month ago (2016-11-10 21:34:03 UTC) #6
Xi Han
Since I revert my first, so I didn't get any conflict when I revert this ...
4 years, 1 month ago (2016-11-10 21:43:17 UTC) #7
Xi Han
Hi Dan, This is a simple revert, and there isn't any change added. I need ...
4 years, 1 month ago (2016-11-10 22:58:28 UTC) #10
gone
lgtm
4 years, 1 month ago (2016-11-10 22:59:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494683004/1
4 years, 1 month ago (2016-11-11 16:38:50 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 16:55:15 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 16:57:04 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce6325156ef6335622e359018f2cd35d98f7693f
Cr-Commit-Position: refs/heads/master@{#431580}

Powered by Google App Engine
This is Rietveld 408576698