Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2464143004: Upstream Context.BIND_EXTERNAL_SERVICE (Closed)

Created:
4 years, 1 month ago by michaelbai
Modified:
4 years, 1 month ago
Reviewers:
boliu, gone
CC:
chromium-reviews, dominickn+watch_chromium.org, jam, pkotwicz+watch_chromium.org, agrieve+watch_chromium.org, darin-cc_chromium.org, zpeng+watch_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Context.BIND_EXTERNAL_SERVICE BUG=592722 Committed: https://crrev.com/47314b9e8fb4caf7a3bc6d91c6a0aad9c0a04109 Cr-Commit-Position: refs/heads/master@{#429642}

Patch Set 1 #

Messages

Total messages: 23 (12 generated)
michaelbai
4 years, 1 month ago (2016-11-02 23:42:08 UTC) #7
boliu
lgtm, but I don't think the sdk has rolled yet: https://bugs.chromium.org/p/chromium/issues/detail?id=623989#c78
4 years, 1 month ago (2016-11-03 04:18:32 UTC) #8
michaelbai
On 2016/11/03 04:18:32, boliu wrote: > lgtm, but I don't think the sdk has rolled ...
4 years, 1 month ago (2016-11-03 04:29:44 UTC) #9
boliu
On 2016/11/03 04:29:44, michaelbai wrote: > On 2016/11/03 04:18:32, boliu wrote: > > lgtm, but ...
4 years, 1 month ago (2016-11-03 04:36:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464143004/1
4 years, 1 month ago (2016-11-03 15:38:58 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/295976)
4 years, 1 month ago (2016-11-03 15:46:38 UTC) #14
michaelbai
dfalcantara@ for WebApkActivity.java
4 years, 1 month ago (2016-11-03 15:54:29 UTC) #16
gone
lgtm
4 years, 1 month ago (2016-11-03 17:16:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464143004/1
4 years, 1 month ago (2016-11-03 17:49:37 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 17:55:31 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 18:14:25 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47314b9e8fb4caf7a3bc6d91c6a0aad9c0a04109
Cr-Commit-Position: refs/heads/master@{#429642}

Powered by Google App Engine
This is Rietveld 408576698