Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 2494683004: Revert "Upstream Context.BIND_EXTERNAL_SERVICE" (2/3) (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
index 8989132dd35b30303dd76a9dbe4cad02a8e7d155..d13663343a10d2c771d01e19f61472c46c265ec4 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
@@ -120,7 +120,10 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
return intent;
}
- public ChildServiceConnection(int bindFlags) {
+ public ChildServiceConnection(int bindFlags, boolean needsExtraBindFlags) {
+ if (needsExtraBindFlags && mCreationParams != null) {
+ bindFlags = mCreationParams.addExtraBindFlags(bindFlags);
+ }
mBindFlags = bindFlags;
}
@@ -223,17 +226,16 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
mCreationParams = creationParams;
int initialFlags = Context.BIND_AUTO_CREATE;
if (mAlwaysInForeground) initialFlags |= Context.BIND_IMPORTANT;
- int extralBindFlags = 0;
- if (isExportedService(inSandbox, mContext, mServiceName)) {
- extralBindFlags = Context.BIND_EXTERNAL_SERVICE;
- }
- mInitialBinding = new ChildServiceConnection(initialFlags | extralBindFlags);
+ // "external service" attribute is approximated by "exported" attribute.
+ // TODO(mnaganov): Update after the release of the next Android SDK.
+ final boolean needsExtraBindFlags = isExportedService(inSandbox, mContext, mServiceName);
+ mInitialBinding = new ChildServiceConnection(initialFlags, needsExtraBindFlags);
mStrongBinding = new ChildServiceConnection(
- Context.BIND_AUTO_CREATE | Context.BIND_IMPORTANT | extralBindFlags);
+ Context.BIND_AUTO_CREATE | Context.BIND_IMPORTANT, needsExtraBindFlags);
mWaivedBinding = new ChildServiceConnection(
- Context.BIND_AUTO_CREATE | Context.BIND_WAIVE_PRIORITY | extralBindFlags);
+ Context.BIND_AUTO_CREATE | Context.BIND_WAIVE_PRIORITY, needsExtraBindFlags);
mModerateBinding = new ChildServiceConnection(
- Context.BIND_AUTO_CREATE | extralBindFlags);
+ Context.BIND_AUTO_CREATE, needsExtraBindFlags);
}
private static boolean isExportedService(boolean inSandbox, Context context,

Powered by Google App Engine
This is Rietveld 408576698