Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/iMEnDLH_oJk/h2ZB9Sv8AQAJ

Note:
1. The url attribute on RTCPeerConnectionIceEvent is not added (it is
not currently in Gecko).
2. The candidate member of RTCIceCandidateEvent and RTCIceCandidateEventInit is
made nullable.
Specs:
https://w3c.github.io/webrtc-pc/#idl-def-rtcicecandidateeventinit

BUG=659286
Committed: https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6
Cr-Commit-Position: refs/heads/master@{#432565}

[lunalu1, 2016-11-10 21:21:09]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[lunalu1, 2016-11-10 21:21:19]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-11-10 21:21:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 23:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 23:49:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lunalu1, 2016-11-11 15:55:52]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 15:56:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2016-11-11 15:56:10]

Patchset #1 (id:20001) has been deleted

[lunalu1, 2016-11-11 15:56:44]

lunalu@chromium.org changed reviewers:
+ foolip@chromium.org

[lunalu1, 2016-11-11 15:56:44]

Hi foolip, could you please take a look at this CL?

Thanks

[foolip, 2016-11-11 16:17:34]

Looks good! This will need some tests, very similar to the other one. It'll also
need an Intent to Ship, but you can mostly copy+paste.

https://codereview.chromium.org/2494553002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.cpp
(right):

https://codereview.chromium.org/2494553002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.cpp:50:
RTCPeerConnectionIceEvent::RTCPeerConnectionIceEvent(
An extra blank line here

https://codereview.chromium.org/2494553002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEventInit.idl
(right):

https://codereview.chromium.org/2494553002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEventInit.idl:9:
// https://github.com/w3c/webrtc-pc/pull/863
That's been merged now so you can remove this comment.

https://codereview.chromium.org/2494553002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEventInit.idl:12:
// DOMString url;
This will be nullable when added.

[foolip, 2016-11-11 16:28:13]

foolip@chromium.org changed reviewers:
+ guidou@chromium.org, hbos@chromium.org

[foolip, 2016-11-11 16:28:14]

This'll also need an LGTM from hbos@ or guidou@.

[commit-bot: I haz the power, 2016-11-11 17:29:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 17:29:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lunalu1, 2016-11-11 20:20:43]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 20:21:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2016-11-11 20:24:55]

Hi Philip,

I added a layout test but I am not really confident with the test result. Could
you please take a look at it?

Thanks

https://codereview.chromium.org/2494553002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.cpp
(right):

https://codereview.chromium.org/2494553002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.cpp:50:
RTCPeerConnectionIceEvent::RTCPeerConnectionIceEvent(
On 2016/11/11 16:17:33, foolip wrote:
> An extra blank line here

Done.

https://codereview.chromium.org/2494553002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEventInit.idl
(right):

https://codereview.chromium.org/2494553002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEventInit.idl:9:
// https://github.com/w3c/webrtc-pc/pull/863
On 2016/11/11 16:17:33, foolip wrote:
> That's been merged now so you can remove this comment.

Done.

https://codereview.chromium.org/2494553002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEventInit.idl:12:
// DOMString url;
On 2016/11/11 16:17:33, foolip wrote:
> This will be nullable when added.

Done.

[foolip, 2016-11-11 21:22:05]

Test lgtm, only the "undefined" issue needs change, the "url" stuff as you see
fit.

https://codereview.chromium.org/2494553002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html
(right):

https://codereview.chromium.org/2494553002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:11:
// TODO(lunalu): default for e.url should be "null" instead of "undefined".
I think this is OK so that this test must be updated if support is added, but if
upstream to web-platform-tests this would be in conflict with what the spec
says. OK to leave as is, but it would also be totally fine to not test url at
all until it's implemented, which could be never.

https://codereview.chromium.org/2494553002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:24:
// TODO(lunalu): should be "undefined" instead of "null".
Actually, null is correct. The reason is a bit nuanced. When converting
dictionaries in https://heycam.github.io/webidl/#es-dictionary there's a "Get(V,
key)" bit, which would return undefined both if the property is there, and if
it's there but has the value undefined. And then undefined is treated as
missing. So null here can be said to be the default value, not the result of
trying to convert undefined to the type "RTCIceCandidate?" That, per
https://heycam.github.io/webidl/#es-nullable-type would have resulted in null
because of "Otherwise, if V is null or undefined, then return the IDL nullable
type T? value null."

The difference doesn't matter here, it's just trivia.

https://codereview.chromium.org/2494553002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:29:
var c = new RTCIceCandidate({ candidate: 'candidate', sdpMid: 'sdpMid',
sdpMLineIndex: 1 });
Unrelated: A look at RTCIceCandidate.idl shows that there are plenty of small
differences to the spec. Another day.

[lunalu1, 2016-11-11 21:37:20]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 21:37:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 23:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 23:12:16]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hbos_chromium, 2016-11-14 15:45:15]

Looks good, I want to see an Intent to Ship. Link?

The link in the CL description does not take me to the section, it should be
https://w3c.github.io/webrtc-pc/#rtcpeerconnectioniceevent.

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html
(right):

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:9:
var e = new RTCPeerConnectionIceEvent('type');
What is 'type'? I don't get it from looking at the spec, is that an Event thing?

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:13:
}, 'RTCPeerConnectionIceEvent constructor with no candidate attribute
provivded');
nit: provided.'

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:18:
}, 'RTCPeerConnectionIceEvent constructor with cnadidate paased as "null".');
nit: candidate passed as null

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:29:
assert_equals(e.url, undefined);
nit: Add a TODO comment here since this assertion checks for incorrect behavior
(url should be 'url' I assume). You could remove it too, but when url is added
having this check forces you to update this test to have it pass which might be
a good thing. Up to you.

[foolip, 2016-11-14 15:49:39]

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html
(right):

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:9:
var e = new RTCPeerConnectionIceEvent('type');
On 2016/11/14 15:45:14, hbos_chromium wrote:
> What is 'type'? I don't get it from looking at the spec, is that an Event
thing?

Yes, all event constructors have it has the first argument. It looks like
https://dom.spec.whatwg.org/#constructing-events spells it out even for
interfaces that inherit from Event, not just Event itself.

[foolip, 2016-11-14 15:50:31]

Description was changed from

==========
Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.


Note:
1. The url attribute on RTCPeerConnectionIceEvent is not added (it is
not currently in Gecko).
2. The candidate member of RTCIceCandidateEvent and RTCIceCandidateEventInit is
made nullable.
Specs:
https://w3c.github.io/webrtc-pc/#idl-def-rtcicecandidateeventinit

BUG=659286
==========

to

==========
Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/iMEnDLH_oJk/h2ZB9Sv8...

Note:
1. The url attribute on RTCPeerConnectionIceEvent is not added (it is
not currently in Gecko).
2. The candidate member of RTCIceCandidateEvent and RTCIceCandidateEventInit is
made nullable.
Specs:
https://w3c.github.io/webrtc-pc/#idl-def-rtcicecandidateeventinit

BUG=659286
==========

[foolip, 2016-11-14 15:50:48]

On 2016/11/14 15:45:15, hbos_chromium wrote:
> Looks good, I want to see an Intent to Ship. Link?

https://groups.google.com/a/chromium.org/d/msg/blink-dev/iMEnDLH_oJk/h2ZB9Sv8...
added to the description.

[hbos_chromium, 2016-11-14 15:53:08]

lgtm with previously mentioned nits fixed

[lunalu1, 2016-11-15 16:15:36]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 16:15:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 17:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 17:55:00]

Dry run: This issue passed the CQ dry run.

[lunalu1, 2016-11-15 18:09:24]

Hi hbos, I have made the changes based on your comments.
Hi Guido, could you please take a look at this CL before I land it?

Thanks

https://codereview.chromium.org/2494553002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html
(right):

https://codereview.chromium.org/2494553002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:11:
// TODO(lunalu): default for e.url should be "null" instead of "undefined".
On 2016/11/11 21:22:05, foolip wrote:
> I think this is OK so that this test must be updated if support is added, but
if
> upstream to web-platform-tests this would be in conflict with what the spec
> says. OK to leave as is, but it would also be totally fine to not test url at
> all until it's implemented, which could be never.

Done.

https://codereview.chromium.org/2494553002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:24:
// TODO(lunalu): should be "undefined" instead of "null".
On 2016/11/11 21:22:05, foolip wrote:
> Actually, null is correct. The reason is a bit nuanced. When converting
> dictionaries in https://heycam.github.io/webidl/#es-dictionary there's a
"Get(V,
> key)" bit, which would return undefined both if the property is there, and if
> it's there but has the value undefined. And then undefined is treated as
> missing. So null here can be said to be the default value, not the result of
> trying to convert undefined to the type "RTCIceCandidate?" That, per
> https://heycam.github.io/webidl/#es-nullable-type would have resulted in null
> because of "Otherwise, if V is null or undefined, then return the IDL nullable
> type T? value null."
> 
> The difference doesn't matter here, it's just trivia.

Done.

https://codereview.chromium.org/2494553002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:29:
var c = new RTCIceCandidate({ candidate: 'candidate', sdpMid: 'sdpMid',
sdpMLineIndex: 1 });
On 2016/11/11 21:22:05, foolip wrote:
> Unrelated: A look at RTCIceCandidate.idl shows that there are plenty of small
> differences to the spec. Another day.

Done.

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html
(right):

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:9:
var e = new RTCPeerConnectionIceEvent('type');
On 2016/11/14 15:45:14, hbos_chromium wrote:
> What is 'type'? I don't get it from looking at the spec, is that an Event
thing?

Done.

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:9:
var e = new RTCPeerConnectionIceEvent('type');
On 2016/11/14 15:49:39, foolip wrote:
> On 2016/11/14 15:45:14, hbos_chromium wrote:
> > What is 'type'? I don't get it from looking at the spec, is that an Event
> thing?
> 
> Yes, all event constructors have it has the first argument. It looks like
> https://dom.spec.whatwg.org/#constructing-events spells it out even for
> interfaces that inherit from Event, not just Event itself.

Done.

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:13:
}, 'RTCPeerConnectionIceEvent constructor with no candidate attribute
provivded');
On 2016/11/14 15:45:15, hbos_chromium wrote:
> nit: provided.'

Done.

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:18:
}, 'RTCPeerConnectionIceEvent constructor with cnadidate paased as "null".');
On 2016/11/14 15:45:15, hbos_chromium wrote:
> nit: candidate passed as null

Done.

https://codereview.chromium.org/2494553002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:29:
assert_equals(e.url, undefined);
On 2016/11/14 15:45:14, hbos_chromium wrote:
> nit: Add a TODO comment here since this assertion checks for incorrect
behavior
> (url should be 'url' I assume). You could remove it too, but when url is added
> having this check forces you to update this test to have it pass which might
be
> a good thing. Up to you.

Done.

[Guido Urdaneta, 2016-11-15 18:23:51]

RS LGTM (provided all of the comments from foolip@ and hbos@ are addressed)

[foolip, 2016-11-15 19:15:21]

lgtm % a few more test nits.

https://codereview.chromium.org/2494553002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html
(right):

https://codereview.chromium.org/2494553002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:18:
}, 'RTCPeerConnectionIceEvent constructor with cnadidate paased as null.');
s/cnadidate paased/candidate passed/

https://codereview.chromium.org/2494553002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:23:
}, 'RTCPeerConnectionIceEvent constructor with candidate paased as
"undefined".');
s/paased/passed/

https://codereview.chromium.org/2494553002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:28:
assert_equals(e.candidate, c);
Also assert_equals(e.type, 'type') in at least one test, and this seems a
reasonable place.

[lunalu1, 2016-11-15 19:26:40]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[lunalu1, 2016-11-15 19:27:01]

Done. Thanks

https://codereview.chromium.org/2494553002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html
(right):

https://codereview.chromium.org/2494553002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:18:
}, 'RTCPeerConnectionIceEvent constructor with cnadidate paased as null.');
On 2016/11/15 19:15:21, foolip wrote:
> s/cnadidate paased/candidate passed/

Done.

https://codereview.chromium.org/2494553002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:23:
}, 'RTCPeerConnectionIceEvent constructor with candidate paased as
"undefined".');
On 2016/11/15 19:15:21, foolip wrote:
> s/paased/passed/

Done.

https://codereview.chromium.org/2494553002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html:28:
assert_equals(e.candidate, c);
On 2016/11/15 19:15:21, foolip wrote:
> Also assert_equals(e.type, 'type') in at least one test, and this seems a
> reasonable place.

Done.

[commit-bot: I haz the power, 2016-11-15 19:27:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 19:42:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 19:42:03]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[lunalu1, 2016-11-15 21:00:02]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 21:00:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2016-11-15 21:07:57]

The CQ bit was checked by lunalu@chromium.org

[lunalu1, 2016-11-15 21:07:57]

The patchset sent to the CQ was uploaded after l-g-t-m from hbos@chromium.org,
guidou@chromium.org, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2494553002/#ps140001
(title: "Run trybox after this CL is landed
https://codereview.chromium.org/2463953002")

[commit-bot: I haz the power, 2016-11-15 21:08:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:21:43]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[lunalu1, 2016-11-15 21:22:40]

The CQ bit was checked by lunalu@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:23:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:41:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:41:53]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[lunalu1, 2016-11-16 15:33:08]

Patchset #6 (id:140001) has been deleted

[lunalu1, 2016-11-16 15:33:13]

The CQ bit was checked by lunalu@chromium.org

[lunalu1, 2016-11-16 15:33:14]

The patchset sent to the CQ was uploaded after l-g-t-m from guidou@chromium.org,
hbos@chromium.org, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2494553002/#ps160001
(title: "Update rebase")

[commit-bot: I haz the power, 2016-11-16 15:33:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 18:28:17]

Description was changed from

==========
Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/iMEnDLH_oJk/h2ZB9Sv8...

Note:
1. The url attribute on RTCPeerConnectionIceEvent is not added (it is
not currently in Gecko).
2. The candidate member of RTCIceCandidateEvent and RTCIceCandidateEventInit is
made nullable.
Specs:
https://w3c.github.io/webrtc-pc/#idl-def-rtcicecandidateeventinit

BUG=659286
==========

to

==========
Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/iMEnDLH_oJk/h2ZB9Sv8...

Note:
1. The url attribute on RTCPeerConnectionIceEvent is not added (it is
not currently in Gecko).
2. The candidate member of RTCIceCandidateEvent and RTCIceCandidateEventInit is
made nullable.
Specs:
https://w3c.github.io/webrtc-pc/#idl-def-rtcicecandidateeventinit

BUG=659286
==========

[commit-bot: I haz the power, 2016-11-16 18:28:19]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2016-11-16 18:52:41]

Description was changed from

==========
Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/iMEnDLH_oJk/h2ZB9Sv8...

Note:
1. The url attribute on RTCPeerConnectionIceEvent is not added (it is
not currently in Gecko).
2. The candidate member of RTCIceCandidateEvent and RTCIceCandidateEventInit is
made nullable.
Specs:
https://w3c.github.io/webrtc-pc/#idl-def-rtcicecandidateeventinit

BUG=659286
==========

to

==========
Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/iMEnDLH_oJk/h2ZB9Sv8...

Note:
1. The url attribute on RTCPeerConnectionIceEvent is not added (it is
not currently in Gecko).
2. The candidate member of RTCIceCandidateEvent and RTCIceCandidateEventInit is
made nullable.
Specs:
https://w3c.github.io/webrtc-pc/#idl-def-rtcicecandidateeventinit

BUG=659286

Committed: https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6
Cr-Commit-Position: refs/heads/master@{#432565}
==========

[commit-bot: I haz the power, 2016-11-16 18:52:42]

Patchset 6 (id:??) landed as
https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6
Cr-Commit-Position: refs/heads/master@{#432565}