third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html - Issue 2494553002: Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html

Issue 2494553002: Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose. (Closed)

Patch Set: Codereview update Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>RTCPeerConnectionIceEvent constructor</title>

	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <script>

	7 test(function() {

	8 assert_equals(RTCPeerConnectionIceEvent.length, 1);

	9 var e = new RTCPeerConnectionIceEvent('type');

	10 assert_equals(e.candidate, null);

	11 assert_false(e.bubbles);

	12 assert_false(e.cancelable);

	13 }, 'RTCPeerConnectionIceEvent constructor with no candidate attribute provided') ;

	14

	15 test(function() {

	16 var e = new RTCPeerConnectionIceEvent('type', { candidate: null });

	17 assert_equals(e.candidate, null);

	18 }, 'RTCPeerConnectionIceEvent constructor with cnadidate paased as null.');
	foolip 2016/11/15 19:15:21 s/cnadidate paased/candidate passed/ s/cnadidate paased/candidate passed/ lunalu1 2016/11/15 19:27:01 Done. Show quoted text On 2016/11/15 19:15:21, foolip wrote: > s/cnadidate paased/candidate passed/ Done.
	19

	20 test(function() {

	21 var e = new RTCPeerConnectionIceEvent('type', { candidate: undefined });

	22 assert_equals(e.candidate, null);

	23 }, 'RTCPeerConnectionIceEvent constructor with candidate paased as "undefined".' );
	foolip 2016/11/15 19:15:21 s/paased/passed/ s/paased/passed/ lunalu1 2016/11/15 19:27:01 Done. Show quoted text On 2016/11/15 19:15:21, foolip wrote: > s/paased/passed/ Done.
	24

	25 test(function() {

	26 var c = new RTCIceCandidate({ candidate: 'candidate', sdpMid: 'sdpMid', sdpMLi neIndex: 1 });

	27 var e = new RTCPeerConnectionIceEvent('type', { candidate: c, url: 'url', bubb les: true, cancelable: true});

	28 assert_equals(e.candidate, c);
	foolip 2016/11/15 19:15:21 Also assert_equals(e.type, 'type') in at least one Also assert_equals(e.type, 'type') in at least one test, and this seems a reasonable place. lunalu1 2016/11/15 19:27:01 Done. Show quoted text On 2016/11/15 19:15:21, foolip wrote: > Also assert_equals(e.type, 'type') in at least one test, and this seems a > reasonable place. Done.
	29 // TODO(lunalu): When url is added to RTCPeerConnectionIceEventInitializer,

	30 // update the assertion to be: "assert_equals(e.url, 'url);".

	31 assert_equals(e.url, undefined);

	32 assert_true(e.bubbles);

	33 assert_true(e.cancelable);

	34 }, 'RTCPeerConnectionIceEvent constructor with full arguments.');

	35 </script>

OLD	NEW