third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html - Issue 2494553002: Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html

Issue 2494553002: Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose. (Closed)

Patch Set: Codereview update Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>RTCPeerConnectionIceEvent constructor</title>

	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <script>

	7 test(function() {

	8 assert_equals(RTCPeerConnectionIceEvent.length, 1);

	9 var e = new RTCPeerConnectionIceEvent('type');
	hbos_chromium 2016/11/14 15:45:14 What is 'type'? I don't get it from looking at the What is 'type'? I don't get it from looking at the spec, is that an Event thing? foolip 2016/11/14 15:49:39 Yes, all event constructors have it has the first Show quoted text On 2016/11/14 15:45:14, hbos_chromium wrote: > What is 'type'? I don't get it from looking at the spec, is that an Event thing? Yes, all event constructors have it has the first argument. It looks like https://dom.spec.whatwg.org/#constructing-events spells it out even for interfaces that inherit from Event, not just Event itself. lunalu1 2016/11/15 18:09:24 Done. Show quoted text On 2016/11/14 15:49:39, foolip wrote: > On 2016/11/14 15:45:14, hbos_chromium wrote: > > What is 'type'? I don't get it from looking at the spec, is that an Event > thing? > > Yes, all event constructors have it has the first argument. It looks like > https://dom.spec.whatwg.org/#constructing-events spells it out even for > interfaces that inherit from Event, not just Event itself. Done. lunalu1 2016/11/15 18:09:24 Done. Show quoted text On 2016/11/14 15:45:14, hbos_chromium wrote: > What is 'type'? I don't get it from looking at the spec, is that an Event thing? Done.
	10 assert_equals(e.candidate, null);

	11 assert_false(e.bubbles);

	12 assert_false(e.cancelable);

	13 }, 'RTCPeerConnectionIceEvent constructor with no candidate attribute provivded' );
	hbos_chromium 2016/11/14 15:45:15 nit: provided.' nit: provided.' lunalu1 2016/11/15 18:09:24 Done. Show quoted text On 2016/11/14 15:45:15, hbos_chromium wrote: > nit: provided.' Done.
	14

	15 test(function() {

	16 var e = new RTCPeerConnectionIceEvent('type', { candidate: null });

	17 assert_equals(e.candidate, null);

	18 }, 'RTCPeerConnectionIceEvent constructor with cnadidate paased as "null".');
	hbos_chromium 2016/11/14 15:45:15 nit: candidate passed as null nit: candidate passed as null lunalu1 2016/11/15 18:09:24 Done. Show quoted text On 2016/11/14 15:45:15, hbos_chromium wrote: > nit: candidate passed as null Done.
	19

	20 test(function() {

	21 var e = new RTCPeerConnectionIceEvent('type', { candidate: undefined });

	22 assert_equals(e.candidate, null);

	23 }, 'RTCPeerConnectionIceEvent constructor with candidate paased as "undefined".' );

	24

	25 test(function() {

	26 var c = new RTCIceCandidate({ candidate: 'candidate', sdpMid: 'sdpMid', sdpMLi neIndex: 1 });

	27 var e = new RTCPeerConnectionIceEvent('type', { candidate: c, url: 'url', bubb les: true, cancelable: true});

	28 assert_equals(e.candidate, c);

	29 assert_equals(e.url, undefined);
	hbos_chromium 2016/11/14 15:45:14 nit: Add a TODO comment here since this assertion nit: Add a TODO comment here since this assertion checks for incorrect behavior (url should be 'url' I assume). You could remove it too, but when url is added having this check forces you to update this test to have it pass which might be a good thing. Up to you. lunalu1 2016/11/15 18:09:24 Done. Show quoted text On 2016/11/14 15:45:14, hbos_chromium wrote: > nit: Add a TODO comment here since this assertion checks for incorrect behavior > (url should be 'url' I assume). You could remove it too, but when url is added > having this check forces you to update this test to have it pass which might be > a good thing. Up to you. Done.
	30 assert_true(e.bubbles);

	31 assert_true(e.cancelable);

	32 }, 'RTCPeerConnectionIceEvent constructor with full arguments.');

	33 </script>

OLD	NEW