Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1678)

Issue 2494353002: Revert of Make SkSmallAllocator obey the RAII invariants and be expandable (Closed)

Created:
4 years, 1 month ago by mtklein_C
Modified:
4 years, 1 month ago
Reviewers:
bungeman-skia, herb_g
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make SkSmallAllocator obey the RAII invariants and be expandable (patchset #15 id:280001 of https://codereview.chromium.org/2488523003/ ) Reason for revert: bots crashing / asserting Original issue's description: > Make SkSmallAllocator obey the RAII invariants and move to heap structures when needed. > > The biggest change is to the API which allowed code to bypass the > destruction invariants. This destruction bypass feature was needed in > only one use, and is totally encapsulated using createWithIniterT. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2488523003 > > Committed: https://skia.googlesource.com/skia/+/d5dc657b8c3ac916f98005dafdedafe02f023449 > Committed: https://skia.googlesource.com/skia/+/c18b5f8f57a4efc5d5d1e399ed8bd3bd02c592ab TBR=bungeman@google.com,herb@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f982cb37e3092e7a69c13a12ec09806ceff5af45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -140 lines) Patch
M src/core/SkBlitter.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M src/core/SkDrawLooper.cpp View 2 chunks +4 lines, -10 lines 0 comments Download
M src/core/SkRasterPipelineBlitter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkSmallAllocator.h View 1 chunk +77 lines, -89 lines 0 comments Download
M tests/LayerDrawLooperTest.cpp View 3 chunks +6 lines, -15 lines 0 comments Download
M tests/SmallAllocatorTest.cpp View 3 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein_C
Created Revert of Make SkSmallAllocator obey the RAII invariants and be expandable
4 years, 1 month ago (2016-11-13 17:54:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494353002/1
4 years, 1 month ago (2016-11-13 17:54:58 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-13 17:55:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f982cb37e3092e7a69c13a12ec09806ceff5af45

Powered by Google App Engine
This is Rietveld 408576698