Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2494213002: Pushing the detailed error messages to dashboard. (Closed)

Created:
4 years, 1 month ago by RobertoCN
Modified:
4 years, 1 month ago
Reviewers:
sullivan
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Pushing the detailed error messages to dashboard. For https://codereview.chromium.org/2498693002/ and https://codereview.chromium.org/2496903004/ to work properly, we need to push the error to dashboard through the 'aborted_message' field. TBR=sullivan@chromium.org BUG=664516 Committed: https://chromium.googlesource.com/chromium/tools/build/+/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M scripts/slave/recipe_modules/auto_bisect_staging/bisector.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_bisect_other_direction.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_linux_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_mac_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win32_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_build.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_buildbucket_get.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_reference_range.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_revision.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_repro.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_values.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/retest_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect_bis.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py View 1 chunk +5 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/failure_in_ref_range.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_failed_device.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
RobertoCN
4 years, 1 month ago (2016-11-11 21:24:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494213002/1
4 years, 1 month ago (2016-11-11 21:24:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb
4 years, 1 month ago (2016-11-11 21:35:09 UTC) #5
sullivan
4 years, 1 month ago (2016-11-12 01:04:47 UTC) #6
Message was sent while issue was closed. 
lgtm

I don't understand why we have a primary result code and then a secondary result
code and then a string message, but the structure is already existing so let's
talk about that after the refactor bugs settle a bit more.

Powered by Google App Engine
This is Rietveld 408576698