Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/bisector.py

Issue 2494213002: Pushing the detailed error messages to dashboard. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_bisect_other_direction.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py b/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
index d9f3fdd85b9ddb646fc251cda147c2428a59f962..d3c7ecb9f69f2d2378fa85d93bbf0465c5bf7506 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
@@ -88,6 +88,7 @@ class Bisector(object):
'improvement_direction', 0)) or None
self.warnings = []
+ self.aborted_reason = None
# Status flags
self.failed_initial_confidence = False
@@ -774,7 +775,7 @@ class Bisector(object):
'good_revision': self.good_rev.commit_hash,
'bad_revision': self.bad_rev.commit_hash,
'warnings': self.warnings,
- 'aborted_reason': aborted_reason,
+ 'aborted_reason': self.aborted_reason or aborted_reason,
'culprit_data': self._culprit_data(),
'revision_data': self._revision_data()
}
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_bisect_other_direction.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698