Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py

Issue 2494213002: Pushing the detailed error messages to dashboard. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py b/scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py
index 36438e0665d60330fe109f9dadb79b34c73adbf5..1a342d3cdcb518170817627b5e7ca521c7e2cfcf 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py
@@ -36,13 +36,15 @@ def perform_bisect(api, **flags):
else:
raise
except bisect_exceptions.InconclusiveBisectException as e:
+ message = 'Bisect cannot identify a culprit: ' + e.message
if bisect_attempts:
+ bisect_attempts[-1].aborted_reason = message
bisect_attempts[-1].print_result_debug_info()
bisect_attempts[-1].post_result()
- raise api.m.step.StepFailure('Bisect cannot identify a culprit: ' +
- e.message)
- except Exception: # pylint: disable=bare-except
+ raise api.m.step.StepFailure(message)
+ except Exception as e: # pylint: disable=bare-except
if bisect_attempts:
+ bisect_attempts[-1].aborted_reason = e.message
bisect_attempts[-1].post_result()
raise

Powered by Google App Engine
This is Rietveld 408576698