Revert "HTTP Bad: Split out UMA metrics for password vs credit card "Not secure" warnings"

Revert "HTTP Bad: Split out UMA metrics for password vs credit card "Not secure" warnings"

This reverts commit 4805cebc1656e9f99905537db6b369bec581ac28.

Original CL: https://codereview.chromium.org/2483423002

Reason for revert:
SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/59826

BUG=663389
TBR=lshang@chromium.org, isherman@chromium.org, estark@chromium.org
NOTRY=true

Committed: https://crrev.com/e9cfde4b3b4587632781f2921e50c4b730bc63d7
Cr-Commit-Position: refs/heads/master@{#431508}

[hiroshige, 2016-11-11 06:20:55]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 06:21:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-11 06:24:57]

Description was changed from

==========
Revert "HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings"

This reverts commit 4805cebc1656e9f99905537db6b369bec581ac28.

BUG=
==========

to

==========
Revert "HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings"

This reverts commit 4805cebc1656e9f99905537db6b369bec581ac28.

Original CL: https://codereview.chromium.org/2483423002

Reason for revert:
SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...

BUG=663389
TBR=lshang@chromium.org, isherman@chromium.org, estark@chromium.org
==========

[hiroshige, 2016-11-11 06:26:00]

Description was changed from

==========
Revert "HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings"

This reverts commit 4805cebc1656e9f99905537db6b369bec581ac28.

Original CL: https://codereview.chromium.org/2483423002

Reason for revert:
SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...

BUG=663389
TBR=lshang@chromium.org, isherman@chromium.org, estark@chromium.org
==========

to

==========
Revert "HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings"

This reverts commit 4805cebc1656e9f99905537db6b369bec581ac28.

Original CL: https://codereview.chromium.org/2483423002

Reason for revert:
SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...

BUG=663389
TBR=lshang@chromium.org, isherman@chromium.org, estark@chromium.org
NOTRY=true
==========

[hiroshige, 2016-11-11 06:26:00]

hiroshige@chromium.org changed reviewers:
+ estark@chromium.org, isherman@chromium.org, lshang@chromium.org

[hiroshige, 2016-11-11 06:26:07]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2016-11-11 06:26:11]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-11-11 06:26:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 06:33:56]

Description was changed from

==========
Revert "HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings"

This reverts commit 4805cebc1656e9f99905537db6b369bec581ac28.

Original CL: https://codereview.chromium.org/2483423002

Reason for revert:
SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...

BUG=663389
TBR=lshang@chromium.org, isherman@chromium.org, estark@chromium.org
NOTRY=true
==========

to

==========
Revert "HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings"

This reverts commit 4805cebc1656e9f99905537db6b369bec581ac28.

Original CL: https://codereview.chromium.org/2483423002

Reason for revert:
SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...

BUG=663389
TBR=lshang@chromium.org, isherman@chromium.org, estark@chromium.org
NOTRY=true
==========

[commit-bot: I haz the power, 2016-11-11 06:33:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-11 06:35:58]

Description was changed from

==========
Revert "HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings"

This reverts commit 4805cebc1656e9f99905537db6b369bec581ac28.

Original CL: https://codereview.chromium.org/2483423002

Reason for revert:
SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...

BUG=663389
TBR=lshang@chromium.org, isherman@chromium.org, estark@chromium.org
NOTRY=true
==========

to

==========
Revert "HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings"

This reverts commit 4805cebc1656e9f99905537db6b369bec581ac28.

Original CL: https://codereview.chromium.org/2483423002

Reason for revert:
SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...

BUG=663389
TBR=lshang@chromium.org, isherman@chromium.org, estark@chromium.org
NOTRY=true

Committed: https://crrev.com/e9cfde4b3b4587632781f2921e50c4b730bc63d7
Cr-Commit-Position: refs/heads/master@{#431508}
==========

[commit-bot: I haz the power, 2016-11-11 06:36:00]

Patchset 1 (id:??) landed as
https://crrev.com/e9cfde4b3b4587632781f2921e50c4b730bc63d7
Cr-Commit-Position: refs/heads/master@{#431508}

[lshang, 2016-11-11 07:12:08]

hiroshige@, why is my CL get reverted? Shouldn't
https://codereview.chromium.org/2484913006 be reverted according to keywords
"system" "tray" "views" in that CLs changelist?

[hiroshige, 2016-11-11 07:23:03]

On 2016/11/11 07:12:08, lshang wrote:
> hiroshige@, why is my CL get reverted? Shouldn't
> https://codereview.chromium.org/2484913006 be reverted according to keywords
> "system" "tray" "views" in that CLs changelist?

Thanks for suggestion.

I'll reland your original CL (r431481) soon and revert r431480 instead.
This revert CL of r431481 didn't resolve the test failure:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...

I reverted r431481 because from the test failure history the first failure was
r431481 and there was no failure for r431480 on multiple bots.

[hiroshige, 2016-11-11 11:46:26]

On 2016/11/11 07:23:03, hiroshige wrote:
> On 2016/11/11 07:12:08, lshang wrote:
> > hiroshige@, why is my CL get reverted? Shouldn't
> > https://codereview.chromium.org/2484913006 be reverted according to keywords
> > "system" "tray" "views" in that CLs changelist?
> 
> Thanks for suggestion.
> 
> I'll reland your original CL (r431481) soon and revert r431480 instead.
> This revert CL of r431481 didn't resolve the test failure:
>
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...
> 
> I reverted r431481 because from the test failure history the first failure was
> r431481 and there was no failure for r431480 on multiple bots.

The original CL https://codereview.chromium.org/2483423002 was relanded.

[chromium-reviews, 2016-11-11 11:46:58]

Thanks!

On Fri, Nov 11, 2016 at 10:46 PM, <hiroshige@chromium.org> wrote:

> On 2016/11/11 07:23:03, hiroshige wrote:
> > On 2016/11/11 07:12:08, lshang wrote:
> > > hiroshige@, why is my CL get reverted? Shouldn't
> > > https://codereview.chromium.org/2484913006 be reverted according to
> keywords
> > > "system" "tray" "views" in that CLs changelist?
> >
> > Thanks for suggestion.
> >
> > I'll reland your original CL (r431481) soon and revert r431480 instead.
> > This revert CL of r431481 didn't resolve the test failure:
> >
> https://build.chromium.org/p/chromium.win/builders/Win7%
> 20Tests%20%281%29/builds/59833
> >
> > I reverted r431481 because from the test failure history the first
> failure was
> > r431481 and there was no failure for r431480 on multiple bots.
>
> The original CL https://codereview.chromium.org/2483423002 was relanded.
>
> https://codereview.chromium.org/2494033002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.