Correct spacing in scroll contents of Ash MD detailed view.

Correct spacing in scroll contents of Ash MD detailed view.

This CL adds 4px vertical spaceing for scroll contents in ScrollContentsViewto
ensure that there is a correct padding between top row and scroll contents.
This also removes spacing between children in ScrollContentsView to comply with
the latest MD design spec.

BUG=632102, 663199, 663457, 663461, 663154, 632025, 632115
TEST=manually verified the layout.

Committed: https://crrev.com/bb150edfa1495353882b799b39e05b0d181bcd9c
Cr-Commit-Position: refs/heads/master@{#431480}

[fukino, 2016-11-09 12:37:51]

fukino@chromium.org changed reviewers:
+ tdanderson@chromium.org

[fukino, 2016-11-09 12:37:52]

PTAL.
Please let me know if you already have a CL to fix them. Thanks!

[tdanderson, 2016-11-09 18:35:18]

LGTM, thanks!

https://codereview.chromium.org/2484913006/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_details_view.cc (right):

https://codereview.chromium.org/2484913006/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_details_view.cc:5: #include
"ash/common/system/tray/tray_details_view.h"
nit: since this will impact all detailed views, please change your BUG= line to
be:

BUG=632102,663199,663457,663461,663154,632025,632115

[fukino, 2016-11-10 17:40:51]

Description was changed from

==========
Correct spacing in scroll contents of Ash MD detailed view.

This CL adds 4px vertical spaceing for scroll contents in ScrollContentsViewto
ensure that there is a correct padding between top row and scroll contents.
This also removes spacing between children in ScrollContentsView to comply with
the latest MD design spec.

BUG=663154
TEST=manually verified the layout.
==========

to

==========
Correct spacing in scroll contents of Ash MD detailed view.

This CL adds 4px vertical spaceing for scroll contents in ScrollContentsViewto
ensure that there is a correct padding between top row and scroll contents.
This also removes spacing between children in ScrollContentsView to comply with
the latest MD design spec.

BUG=632102,663199,663457,663461,663154,632025,632115
TEST=manually verified the layout.
==========

[fukino, 2016-11-10 17:43:34]

On 2016/11/09 18:35:18, tdanderson wrote:
> LGTM, thanks!
> 
>
https://codereview.chromium.org/2484913006/diff/1/ash/common/system/tray/tray...
> File ash/common/system/tray/tray_details_view.cc (right):
> 
>
https://codereview.chromium.org/2484913006/diff/1/ash/common/system/tray/tray...
> ash/common/system/tray/tray_details_view.cc:5: #include
> "ash/common/system/tray/tray_details_view.h"
> nit: since this will impact all detailed views, please change your BUG= line
to
> be:
> 
> BUG=632102,663199,663457,663461,663154,632025,632115

Thank you for the review and the list of affected bugs!
I'm holding this CL for a clarification of the padding position.
https://bugs.chromium.org/p/chromium/issues/detail?id=663154#c3
I'll commit or revise this once it gets clear.

[fukino, 2016-11-11 02:33:21]

Landing based on
https://bugs.chromium.org/p/chromium/issues/detail?id=663154#c4.

[fukino, 2016-11-11 02:33:25]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-11-11 02:34:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 03:11:39]

Description was changed from

==========
Correct spacing in scroll contents of Ash MD detailed view.

This CL adds 4px vertical spaceing for scroll contents in ScrollContentsViewto
ensure that there is a correct padding between top row and scroll contents.
This also removes spacing between children in ScrollContentsView to comply with
the latest MD design spec.

BUG=632102,663199,663457,663461,663154,632025,632115
TEST=manually verified the layout.
==========

to

==========
Correct spacing in scroll contents of Ash MD detailed view.

This CL adds 4px vertical spaceing for scroll contents in ScrollContentsViewto
ensure that there is a correct padding between top row and scroll contents.
This also removes spacing between children in ScrollContentsView to comply with
the latest MD design spec.

BUG=632102,663199,663457,663461,663154,632025,632115
TEST=manually verified the layout.
==========

[commit-bot: I haz the power, 2016-11-11 03:11:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-11 03:15:44]

Description was changed from

==========
Correct spacing in scroll contents of Ash MD detailed view.

This CL adds 4px vertical spaceing for scroll contents in ScrollContentsViewto
ensure that there is a correct padding between top row and scroll contents.
This also removes spacing between children in ScrollContentsView to comply with
the latest MD design spec.

BUG=632102,663199,663457,663461,663154,632025,632115
TEST=manually verified the layout.
==========

to

==========
Correct spacing in scroll contents of Ash MD detailed view.

This CL adds 4px vertical spaceing for scroll contents in ScrollContentsViewto
ensure that there is a correct padding between top row and scroll contents.
This also removes spacing between children in ScrollContentsView to comply with
the latest MD design spec.

BUG=632102,663199,663457,663461,663154,632025,632115
TEST=manually verified the layout.

Committed: https://crrev.com/bb150edfa1495353882b799b39e05b0d181bcd9c
Cr-Commit-Position: refs/heads/master@{#431480}
==========

[commit-bot: I haz the power, 2016-11-11 03:15:45]

Patchset 1 (id:??) landed as
https://crrev.com/bb150edfa1495353882b799b39e05b0d181bcd9c
Cr-Commit-Position: refs/heads/master@{#431480}

[hiroshige, 2016-11-11 07:30:48]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2500433002/ by hiroshige@chromium.org.

The reason for reverting is: Suspected to cause
SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...

according to keywords "system" "tray" "views" in the description.


.