Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2493673005: Remove workaround for paint invalidation about percentage transform (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove workaround for paint invalidation about percentage transform It was for descendants of objects with percentage transform, to handle the case that paint offset changed but no other paint invalidation geometry changed. Now the case is covered by the ancestor location change condition. Paint offset change should either caused by self layout change, self location change or ancestor location change, all of which are handled properly by the current code. Debugged a bit with the test case and the version that the logic was added (https://crrev.com/787d405d41fcb60aa0a8e45b0c6e5d4a9bbe75d5), and found that positionFromPaintInvalidationBacking of the transformed contiainer was incorrect. It kept unchanged when running the test. In the current code the value is correct. BUG=533277 TEST=paint/invalidation/percentage-transform-paint-offset.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/469897a8f942f3e8fa46ad71a5c2bac8f3bdcba0 Cr-Commit-Position: refs/heads/master@{#431419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 2 chunks +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 2 chunks +0 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
Xianzhu
4 years, 1 month ago (2016-11-10 23:28:47 UTC) #6
chrishtr
lgtm
4 years, 1 month ago (2016-11-11 00:34:37 UTC) #10
chrishtr
Nice
4 years, 1 month ago (2016-11-11 00:34:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493673005/1
4 years, 1 month ago (2016-11-11 00:35:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 00:40:50 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:45:52 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/469897a8f942f3e8fa46ad71a5c2bac8f3bdcba0
Cr-Commit-Position: refs/heads/master@{#431419}

Powered by Google App Engine
This is Rietveld 408576698