Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2493673005: Remove workaround for paint invalidation about percentage transform (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintInvalidator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index a707e836c4c8019810e10edde6ed38fad323ede4..1006f861af8ccd77204ddfcadca18884635fdf42 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -471,18 +471,6 @@ void LayoutBoxModelObject::addLayerHitTestRects(
}
}
-static bool hasPercentageTransform(const ComputedStyle& style) {
- if (TransformOperation* translate = style.translate()) {
- if (translate->dependsOnBoxSize())
- return true;
- }
- return style.transform().dependsOnBoxSize() ||
- (style.transformOriginX() != Length(50, Percent) &&
- style.transformOriginX().isPercentOrCalc()) ||
- (style.transformOriginY() != Length(50, Percent) &&
- style.transformOriginY().isPercentOrCalc());
-}
-
DISABLE_CFI_PERF
void LayoutBoxModelObject::invalidateTreeIfNeeded(
const PaintInvalidationState& paintInvalidationState) {
@@ -510,16 +498,6 @@ void LayoutBoxModelObject::invalidateTreeIfNeeded(
.setForceSubtreeInvalidationCheckingWithinContainer();
}
- // TODO(wangxianzhu): Combine this function into LayoutObject::
- // invalidateTreeIfNeeded() when removing the following workarounds.
-
- // TODO(wangxianzhu): This is a workaround for crbug.com/533277. Will remove
- // when we enable paint offset caching.
- if (reason != PaintInvalidationNone && hasPercentageTransform(styleRef())) {
- newPaintInvalidationState
- .setForceSubtreeInvalidationCheckingWithinContainer();
- }
-
// TODO(wangxianzhu): This is a workaround for crbug.com/490725. We don't have
// enough saved information to do accurate check of clipping change. Will
// remove when we remove rect-based paint invalidation.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintInvalidator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698