Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Issue 2493673005: Remove workaround for paint invalidation about percentage transform (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
index ae82764dc2734a175579fa0bf7c61d7246ea600f..7145cd021f04537b6e4252f12e2a21a94ae671b9 100644
--- a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
@@ -369,18 +369,6 @@ void PaintInvalidator::invalidatePaintIfNeeded(
layoutView->sendMediaPositionChangeNotifications(visibleRect);
}
-static bool hasPercentageTransform(const ComputedStyle& style) {
- if (TransformOperation* translate = style.translate()) {
- if (translate->dependsOnBoxSize())
- return true;
- }
- return style.transform().dependsOnBoxSize() ||
- (style.transformOriginX() != Length(50, Percent) &&
- style.transformOriginX().isPercentOrCalc()) ||
- (style.transformOriginY() != Length(50, Percent) &&
- style.transformOriginY().isPercentOrCalc());
-}
-
void PaintInvalidator::invalidatePaintIfNeeded(
const LayoutObject& object,
PaintInvalidatorContext& context) {
@@ -434,13 +422,6 @@ void PaintInvalidator::invalidatePaintIfNeeded(
context.forcedSubtreeInvalidationFlags |=
PaintInvalidatorContext::ForcedSubtreeInvalidationChecking;
- // TODO(crbug.com/533277): This is a workaround for the bug. Remove when we
- // detect paint offset change.
- if (reason != PaintInvalidationNone &&
- hasPercentageTransform(object.styleRef()))
- context.forcedSubtreeInvalidationFlags |=
- PaintInvalidatorContext::ForcedSubtreeInvalidationChecking;
-
// TODO(crbug.com/490725): This is a workaround for the bug, to force
// descendant to update visual rects on clipping change.
if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() &&
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698