Remove IPC::Endpoint.

Remove IPC::Endpoint.

BUG=659448
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908
Cr-Commit-Position: refs/heads/master@{#431381}

[Sam McNally, 2016-11-09 22:16:27]

Description was changed from

==========
Remove IPC::Endpoint.

BUG=659448
==========

to

==========
Remove IPC::Endpoint.

BUG=659448
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Sam McNally, 2016-11-09 22:16:50]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 22:17:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 00:39:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 00:39:41]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-10 00:42:11]

sammc@chromium.org changed reviewers:
+ piman@chromium.org, rjkroege@chromium.org, rockot@chromium.org

[Sam McNally, 2016-11-10 00:42:11]

+rjkroege for //ui/ozone

+piman for //content, //gpu and //ppapi/proxy

+rockot for //ipc

[piman, 2016-11-10 01:11:15]

LGTM overall, but please see nit.

https://codereview.chromium.org/2493623002/diff/1/gpu/ipc/service/gpu_channel.cc
File gpu/ipc/service/gpu_channel.cc (right):

https://codereview.chromium.org/2493623002/diff/1/gpu/ipc/service/gpu_channel...
gpu/ipc/service/gpu_channel.cc:645: base::ProcessId GpuChannel::GetClientPID()
const {
nit: can you add a DCHECK that peer_pid_ is not kNullProcessId? I have a slight
worry that there could be a race. Previous to this CL, channel_->GetPeerPID()
would be the right value as soon as the channel is connected on the IO thread,
but now, we'd only have the pid here after the
ChannelProxy::Context::OnDispatchConnected task executes. There are a few cases
that could cause something to try to obtain the pid "too early", for example a
filter posting a task from OnFilterAdded or OnChannelConnected, or an IPC
dispatched re-entrantly from a sync message. I think I convinced myself that
none of these cases happen today, but I would like to defend against such case
creeping in in the future.

[Sam McNally, 2016-11-10 03:23:10]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 03:23:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 04:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 04:18:22]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-10 04:19:43]

https://codereview.chromium.org/2493623002/diff/1/gpu/ipc/service/gpu_channel.cc
File gpu/ipc/service/gpu_channel.cc (right):

https://codereview.chromium.org/2493623002/diff/1/gpu/ipc/service/gpu_channel...
gpu/ipc/service/gpu_channel.cc:645: base::ProcessId GpuChannel::GetClientPID()
const {
On 2016/11/10 01:11:15, piman wrote:
> nit: can you add a DCHECK that peer_pid_ is not kNullProcessId? I have a
slight
> worry that there could be a race. Previous to this CL, channel_->GetPeerPID()
> would be the right value as soon as the channel is connected on the IO thread,
> but now, we'd only have the pid here after the
> ChannelProxy::Context::OnDispatchConnected task executes. There are a few
cases
> that could cause something to try to obtain the pid "too early", for example a
> filter posting a task from OnFilterAdded or OnChannelConnected, or an IPC
> dispatched re-entrantly from a sync message. I think I convinced myself that
> none of these cases happen today, but I would like to defend against such case
> creeping in in the future.

Done.

[Ken Rockot(use gerrit already), 2016-11-10 04:39:49]

lgtm

[rjkroege, 2016-11-10 18:12:12]

ozone lgtm

[Sam McNally, 2016-11-10 22:27:31]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-11-10 22:27:31]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2493623002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-11-10 22:28:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 22:35:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-10 23:10:21]

Description was changed from

==========
Remove IPC::Endpoint.

BUG=659448
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove IPC::Endpoint.

BUG=659448
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908
Cr-Commit-Position: refs/heads/master@{#431381}
==========

[commit-bot: I haz the power, 2016-11-10 23:10:22]

Patchset 2 (id:??) landed as
https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908
Cr-Commit-Position: refs/heads/master@{#431381}