Cleanup methds in IFWL_MonthCalendar

Cleanup methds in IFWL_MonthCalendar

This CL cleans up the methods and parameters in IFWL_MonthCalendar.

Committed: https://pdfium.googlesource.com/pdfium/+/cb8da9d7e283ac6437eabd63bf5543e56910abfc

[dsinclair, 2016-11-09 20:10:48]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-09 20:10:48]

PTAL.

[Tom Sepez, 2016-11-09 21:13:11]

lgtm

https://codereview.chromium.org/2493583002/diff/1/xfa/fwl/core/ifwl_monthcale...
File xfa/fwl/core/ifwl_monthcalendar.cpp (right):

https://codereview.chromium.org/2493583002/diff/1/xfa/fwl/core/ifwl_monthcale...
xfa/fwl/core/ifwl_monthcalendar.cpp:921: if (iDay <= 0 || iDay >
m_arrDates.GetSize()) {
nit: no {}

[npm, 2016-11-09 21:34:15]

https://codereview.chromium.org/2493583002/diff/1/xfa/fwl/core/ifwl_monthcale...
File xfa/fwl/core/ifwl_monthcalendar.h (right):

https://codereview.chromium.org/2493583002/diff/1/xfa/fwl/core/ifwl_monthcale...
xfa/fwl/core/ifwl_monthcalendar.h:40: struct FWL_DATEINFO {
You might be able to forward declare and put inside namespace of the cpp
(when you merge datetimecalendar and monthcalendar)

[dsinclair, 2016-11-10 18:04:16]

https://codereview.chromium.org/2493583002/diff/1/xfa/fwl/core/ifwl_monthcale...
File xfa/fwl/core/ifwl_monthcalendar.cpp (right):

https://codereview.chromium.org/2493583002/diff/1/xfa/fwl/core/ifwl_monthcale...
xfa/fwl/core/ifwl_monthcalendar.cpp:921: if (iDay <= 0 || iDay >
m_arrDates.GetSize()) {
On 2016/11/09 21:13:11, Tom Sepez wrote:
> nit: no {}

Done.

https://codereview.chromium.org/2493583002/diff/1/xfa/fwl/core/ifwl_monthcale...
File xfa/fwl/core/ifwl_monthcalendar.h (right):

https://codereview.chromium.org/2493583002/diff/1/xfa/fwl/core/ifwl_monthcale...
xfa/fwl/core/ifwl_monthcalendar.h:40: struct FWL_DATEINFO {
On 2016/11/09 21:34:14, npm wrote:
> You might be able to forward declare and put inside namespace of the cpp
> (when you merge datetimecalendar and monthcalendar)

Done.

[dsinclair, 2016-11-10 21:02:15]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-10 21:02:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2493583002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-11-10 21:02:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 21:17:56]

Description was changed from

==========
Cleanup methds in IFWL_MonthCalendar

This CL cleans up the methods and parameters in IFWL_MonthCalendar.
==========

to

==========
Cleanup methds in IFWL_MonthCalendar

This CL cleans up the methods and parameters in IFWL_MonthCalendar.

Committed:
https://pdfium.googlesource.com/pdfium/+/cb8da9d7e283ac6437eabd63bf5543e56910...
==========

[commit-bot: I haz the power, 2016-11-10 21:17:57]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/cb8da9d7e283ac6437eabd63bf5543e56910...