Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2491443003: Fold IFWL_DateTimeCalendar into IFWL_MonthCalendar (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fold IFWL_DateTimeCalendar into IFWL_MonthCalendar The IFWL_MonthCalendar was never instantiated and had a single sub-class. This CL folds the subclass into IFWL_MonthCalendar and uses MonthCalendar directly. Committed: https://pdfium.googlesource.com/pdfium/+/72f15a08aa47afb61e3c60b3f754309696c471ec

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -274 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D xfa/fwl/core/ifwl_datetimecalendar.h View 1 chunk +0 lines, -31 lines 0 comments Download
D xfa/fwl/core/ifwl_datetimecalendar.cpp View 1 chunk +0 lines, -184 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.cpp View 5 chunks +78 lines, -47 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL. Note, this doesn't cleanup any nits, just merges the two classes to keep it ...
4 years, 1 month ago (2016-11-09 19:51:02 UTC) #2
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-09 21:09:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491443003/40001
4 years, 1 month ago (2016-11-10 20:48:27 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 21:01:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/72f15a08aa47afb61e3c60b3f754309696c4...

Powered by Google App Engine
This is Rietveld 408576698