Fix srcset selection bug when 'w' and src are present

Fix srcset selection bug when 'w' and src are present

When srcset had 'w' based resources that are all smaller than their display size imposed by 'sizes',
src got picked, contrary to expected behavior.
This CL fixes that and adds regression tests for that case.

BUG=365787
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172458

[eseidel, 2014-04-23 20:55:27]

lgtm

https://codereview.chromium.org/249353002/diff/50001/Source/core/html/parser/...
File Source/core/html/parser/HTMLSrcsetParser.cpp (right):

https://codereview.chromium.org/249353002/diff/50001/Source/core/html/parser/...
Source/core/html/parser/HTMLSrcsetParser.cpp:168: --i;
And i is never 0 here? can't fall off the end of the array?

[Yoav Weiss, 2014-04-23 21:00:17]

On 2014/04/23 20:55:27, eseidel wrote:
> lgtm
> 
>
https://codereview.chromium.org/249353002/diff/50001/Source/core/html/parser/...
> File Source/core/html/parser/HTMLSrcsetParser.cpp (right):
> 
>
https://codereview.chromium.org/249353002/diff/50001/Source/core/html/parser/...
> Source/core/html/parser/HTMLSrcsetParser.cpp:168: --i;
> And i is never 0 here? can't fall off the end of the array?

(ignoreSrc==true && i==0) is not possible. I can add an ASSERT that says that.

[Yoav Weiss, 2014-04-23 21:28:35]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2014-04-23 21:29:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/249353002/40005

[commit-bot: I haz the power, 2014-04-23 21:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 21:57:19]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[Yoav Weiss, 2014-04-23 22:06:44]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2014-04-23 22:06:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/249353002/40005

[commit-bot: I haz the power, 2014-04-23 22:23:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 22:23:16]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[Yoav Weiss, 2014-04-24 05:06:44]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2014-04-24 05:06:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/249353002/40005

[commit-bot: I haz the power, 2014-04-24 06:16:45]

Change committed as 172458