LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html - Issue 249353002: Fix srcset selection bug when 'w' and src are present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html

Issue 249353002: Fix srcset selection bug when 'w' and src are present (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@calc

Patch Set: Added assert Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x-expected.txt ('k') | Source/core/html/parser/HTMLSrcsetParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html

diff --git a/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html b/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html

index 0772734e323c714a9b4be8cae531705eae90e6a6..6c0b7408c7a40bbb772cc043aead5ac40bda66d1 100644

--- a/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html

+++ b/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html

@@ -16,6 +16,6 @@

<div>This test passes if this img tag below is a green square regardless of the scale factor. It ensures that invalid inputs

from srcset are ignored, and src is selected (since it's the only candidate left)</div>

- <img id="foo" src="resources/green-400-px-square.png" srcset="1x 5w, , , resources/blue-100-px-square.png 2px, 2x 3h,,">

+ <img id="foo" src="resources/green-400-px-square.png" srcset="1x 5z, , , resources/blue-100-px-square.png 2px, 2x 3h,,">

</body>

</html>

« no previous file with comments | « LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x-expected.txt ('k') | Source/core/html/parser/HTMLSrcsetParser.cpp » ('j') | no next file with comments »