Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2493193002:
Enable -Wsign-compare compiler warnings. (Closed)
DescriptionEnable -Wsign-compare compiler warnings.
BUG=v8:5614
Committed: https://crrev.com/e5b152264e03620498aa045a8e91930191f4786f
Cr-Commit-Position: refs/heads/master@{#40958}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : fix constant-array-builder-unittest.cc #
Total comments: 2
Messages
Total messages: 32 (22 generated)
ulan@chromium.org changed reviewers: + jochen@chromium.org, machenbach@chromium.org
ptal
LGTM
The CQ bit was checked by ulan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/16040)
The CQ bit was checked by ulan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/16080) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16123) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
The CQ bit was checked by ulan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/16086) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/12394)
ulan@chromium.org changed reviewers: + mstarzinger@chromium.org
Adding Michael for ignition test file review.
The CQ bit was checked by ulan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + thakis@chromium.org
https://codereview.chromium.org/2493193002/diff/60001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2493193002/diff/60001/BUILD.gn#newcode377 BUILD.gn:377: "-Wsign-compare", This is part of -Wextra. I guess you don't build with -Wextra?
https://codereview.chromium.org/2493193002/diff/60001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2493193002/diff/60001/BUILD.gn#newcode377 BUILD.gn:377: "-Wsign-compare", On 2016/11/11 15:19:20, Nico wrote: > This is part of -Wextra. I guess you don't build with -Wextra? That's right.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
LGTM on unit-test, didn't look at the build files.
The CQ bit was checked by ulan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2493193002/#ps60001 (title: "fix constant-array-builder-unittest.cc")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Enable -Wsign-compare compiler warnings. BUG=v8:5614 ========== to ========== Enable -Wsign-compare compiler warnings. BUG=v8:5614 Committed: https://crrev.com/e5b152264e03620498aa045a8e91930191f4786f Cr-Commit-Position: refs/heads/master@{#40958} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e5b152264e03620498aa045a8e91930191f4786f Cr-Commit-Position: refs/heads/master@{#40958} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
