Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gypfiles/standalone.gypi

Issue 2493193002: Enable -Wsign-compare compiler warnings. (Closed)
Patch Set: fix constant-array-builder-unittest.cc Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« BUILD.gn ('K') | « BUILD.gn ('k') | test/unittests/interpreter/constant-array-builder-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gypfiles/standalone.gypi
diff --git a/gypfiles/standalone.gypi b/gypfiles/standalone.gypi
index 5fefe199d6e13b01fdd52ac7a75e522bee2fcb7d..d438a5aeab992e3d09e86c109e1944829218a8e5 100644
--- a/gypfiles/standalone.gypi
+++ b/gypfiles/standalone.gypi
@@ -455,6 +455,7 @@
'variables': {
'v8_code%': '<(v8_code)',
'clang_warning_flags': [
+ '-Wsign-compare',
# TODO(thakis): https://crbug.com/604888
'-Wno-undefined-var-template',
# TODO(yangguo): issue 5258
@@ -504,7 +505,6 @@
'conditions':[
['clang==0', {
'cflags+': [
- '-Wno-sign-compare',
'-Wno-uninitialized',
],
}],
« BUILD.gn ('K') | « BUILD.gn ('k') | test/unittests/interpreter/constant-array-builder-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698