BUILD.gn - Issue 2493193002: Enable -Wsign-compare compiler warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 2493193002: Enable -Wsign-compare compiler warnings. (Closed)

Patch Set: fix constant-array-builder-unittest.cc Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 93f4732ccae943c245ee50273a668bd853bd904f..4c805c705d1de9d53393f3fc66ef4090f6610874 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -374,6 +374,8 @@ config("toolchain") {

if (is_clang) {

cflags += [

+ "-Wsign-compare",

Nico 2016/11/11 15:19:20 This is part of -Wextra. I guess you don't build w

ulan 2016/11/11 15:20:49 That's right.

# TODO(hans): Remove once http://crbug.com/428099 is resolved.

"-Winconsistent-missing-override",

]

« no previous file with comments | « no previous file | gypfiles/standalone.gypi » ('j') | no next file with comments »