Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2492793005: [wasm] Fix more -Wsign-compare warnings. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix more -Wsign-compare warnings. BUG=v8:5614 Committed: https://crrev.com/9c25d5dc6edb5e0c17e40c92951ea934b2715446 Cr-Commit-Position: refs/heads/master@{#40914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -203 lines) Patch
M src/asmjs/asm-types.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/ast-decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-run-wasm-relocation-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-run-wasm-relocation-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-run-wasm-relocation-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-asmjs.cc View 5 chunks +43 lines, -39 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-js.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-relocation.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/asm-types-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 8 chunks +22 lines, -19 lines 0 comments Download
M test/unittests/wasm/decoder-unittest.cc View 15 chunks +38 lines, -38 lines 0 comments Download
M test/unittests/wasm/leb-helper-unittest.cc View 1 chunk +22 lines, -22 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 21 chunks +65 lines, -64 lines 0 comments Download
M test/unittests/wasm/wasm-macro-gen-unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
ptal, after this wasm compiles without warnings both in release and debug modes.
4 years, 1 month ago (2016-11-11 10:44:39 UTC) #2
ahaas
lgtm, thanks a lot!
4 years, 1 month ago (2016-11-11 10:49:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492793005/1
4 years, 1 month ago (2016-11-11 11:30:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 11:55:36 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:14 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9c25d5dc6edb5e0c17e40c92951ea934b2715446
Cr-Commit-Position: refs/heads/master@{#40914}

Powered by Google App Engine
This is Rietveld 408576698