test/cctest/wasm/test-run-wasm-64.cc - Issue 2492793005: [wasm] Fix more -Wsign-compare warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/wasm/test-run-wasm-64.cc

Issue 2492793005: [wasm] Fix more -Wsign-compare warnings. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/wasm/test-run-wasm-64.cc

diff --git a/test/cctest/wasm/test-run-wasm-64.cc b/test/cctest/wasm/test-run-wasm-64.cc

index 36558b0c93fbcfc4d2267f0db78388243bc09085..e9a2d2da478ba47e3902432e31826c3287c96a08 100644

--- a/test/cctest/wasm/test-run-wasm-64.cc

+++ b/test/cctest/wasm/test-run-wasm-64.cc

@@ -300,7 +300,7 @@ WASM_EXEC_TEST(I64DivU_Trap) {

WasmRunner<uint64_t> r(execution_mode, MachineType::Uint64(),

MachineType::Uint64());

BUILD(r, WASM_I64_DIVU(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));

- CHECK_EQ(0, r.Call(asu64(0), asu64(100)));

+ CHECK_EQ(0u, r.Call(asu64(0), asu64(100)));

CHECK_TRAP64(r.Call(asu64(100), asu64(0)));

CHECK_TRAP64(r.Call(asu64(1001), asu64(0)));

CHECK_TRAP64(r.Call(std::numeric_limits<uint64_t>::max(), asu64(0)));

@@ -371,7 +371,7 @@ WASM_EXEC_TEST(I64RemU_Trap) {

WasmRunner<uint64_t> r(execution_mode, MachineType::Uint64(),

MachineType::Uint64());

BUILD(r, WASM_I64_REMU(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));

- CHECK_EQ(17, r.Call(asu64(217), asu64(100)));

+ CHECK_EQ(17u, r.Call(asu64(217), asu64(100)));

CHECK_TRAP64(r.Call(asu64(100), asu64(0)));

CHECK_TRAP64(r.Call(asu64(1001), asu64(0)));

CHECK_TRAP64(r.Call(std::numeric_limits<uint64_t>::max(), asu64(0)));

« no previous file with comments | « test/cctest/wasm/test-run-wasm.cc ('k') | test/cctest/wasm/test-run-wasm-asmjs.cc » ('j') | no next file with comments »