Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: test/unittests/wasm/leb-helper-unittest.cc

Issue 2492793005: [wasm] Fix more -Wsign-compare warnings. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/wasm/decoder-unittest.cc ('k') | test/unittests/wasm/module-decoder-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/wasm/leb-helper-unittest.cc
diff --git a/test/unittests/wasm/leb-helper-unittest.cc b/test/unittests/wasm/leb-helper-unittest.cc
index ff7bedc4cfcfc2f0dc374c9dc29c0167ae30ec1f..6fd91e464fbb39fe1cd311a3fda7aa92e5104993 100644
--- a/test/unittests/wasm/leb-helper-unittest.cc
+++ b/test/unittests/wasm/leb-helper-unittest.cc
@@ -15,76 +15,76 @@ namespace wasm {
class LEBHelperTest : public TestWithZone {};
TEST_F(LEBHelperTest, sizeof_u32v) {
- EXPECT_EQ(1, LEBHelper::sizeof_u32v(0));
- EXPECT_EQ(1, LEBHelper::sizeof_u32v(1));
- EXPECT_EQ(1, LEBHelper::sizeof_u32v(3));
+ EXPECT_EQ(1u, LEBHelper::sizeof_u32v(0));
+ EXPECT_EQ(1u, LEBHelper::sizeof_u32v(1));
+ EXPECT_EQ(1u, LEBHelper::sizeof_u32v(3));
for (uint32_t i = 4; i < 128; i++) {
- EXPECT_EQ(1, LEBHelper::sizeof_u32v(i));
+ EXPECT_EQ(1u, LEBHelper::sizeof_u32v(i));
}
for (uint32_t i = (1u << 7); i < (1u << 9); i++) {
- EXPECT_EQ(2, LEBHelper::sizeof_u32v(i));
+ EXPECT_EQ(2u, LEBHelper::sizeof_u32v(i));
}
for (uint32_t i = (1u << 14); i < (1u << 16); i += 33) {
- EXPECT_EQ(3, LEBHelper::sizeof_u32v(i));
+ EXPECT_EQ(3u, LEBHelper::sizeof_u32v(i));
}
for (uint32_t i = (1u << 21); i < (1u << 24); i += 33999) {
- EXPECT_EQ(4, LEBHelper::sizeof_u32v(i));
+ EXPECT_EQ(4u, LEBHelper::sizeof_u32v(i));
}
for (uint32_t i = (1u << 28); i < (1u << 31); i += 33997779u) {
- EXPECT_EQ(5, LEBHelper::sizeof_u32v(i));
+ EXPECT_EQ(5u, LEBHelper::sizeof_u32v(i));
}
- EXPECT_EQ(5, LEBHelper::sizeof_u32v(0xFFFFFFFF));
+ EXPECT_EQ(5u, LEBHelper::sizeof_u32v(0xFFFFFFFF));
}
TEST_F(LEBHelperTest, sizeof_i32v) {
- EXPECT_EQ(1, LEBHelper::sizeof_i32v(0));
- EXPECT_EQ(1, LEBHelper::sizeof_i32v(1));
- EXPECT_EQ(1, LEBHelper::sizeof_i32v(3));
+ EXPECT_EQ(1u, LEBHelper::sizeof_i32v(0));
+ EXPECT_EQ(1u, LEBHelper::sizeof_i32v(1));
+ EXPECT_EQ(1u, LEBHelper::sizeof_i32v(3));
for (int32_t i = 0; i < (1 << 6); i++) {
- EXPECT_EQ(1, LEBHelper::sizeof_i32v(i));
+ EXPECT_EQ(1u, LEBHelper::sizeof_i32v(i));
}
for (int32_t i = (1 << 6); i < (1 << 8); i++) {
- EXPECT_EQ(2, LEBHelper::sizeof_i32v(i));
+ EXPECT_EQ(2u, LEBHelper::sizeof_i32v(i));
}
for (int32_t i = (1 << 13); i < (1 << 15); i += 31) {
- EXPECT_EQ(3, LEBHelper::sizeof_i32v(i));
+ EXPECT_EQ(3u, LEBHelper::sizeof_i32v(i));
}
for (int32_t i = (1 << 20); i < (1 << 22); i += 31991) {
- EXPECT_EQ(4, LEBHelper::sizeof_i32v(i));
+ EXPECT_EQ(4u, LEBHelper::sizeof_i32v(i));
}
for (int32_t i = (1 << 27); i < (1 << 29); i += 3199893) {
- EXPECT_EQ(5, LEBHelper::sizeof_i32v(i));
+ EXPECT_EQ(5u, LEBHelper::sizeof_i32v(i));
}
for (int32_t i = -(1 << 6); i <= 0; i++) {
- EXPECT_EQ(1, LEBHelper::sizeof_i32v(i));
+ EXPECT_EQ(1u, LEBHelper::sizeof_i32v(i));
}
for (int32_t i = -(1 << 13); i < -(1 << 6); i++) {
- EXPECT_EQ(2, LEBHelper::sizeof_i32v(i));
+ EXPECT_EQ(2u, LEBHelper::sizeof_i32v(i));
}
for (int32_t i = -(1 << 20); i < -(1 << 18); i += 11) {
- EXPECT_EQ(3, LEBHelper::sizeof_i32v(i));
+ EXPECT_EQ(3u, LEBHelper::sizeof_i32v(i));
}
for (int32_t i = -(1 << 27); i < -(1 << 25); i += 11999) {
- EXPECT_EQ(4, LEBHelper::sizeof_i32v(i));
+ EXPECT_EQ(4u, LEBHelper::sizeof_i32v(i));
}
for (int32_t i = -(1 << 30); i < -(1 << 28); i += 1199999) {
- EXPECT_EQ(5, LEBHelper::sizeof_i32v(i));
+ EXPECT_EQ(5u, LEBHelper::sizeof_i32v(i));
}
}
« no previous file with comments | « test/unittests/wasm/decoder-unittest.cc ('k') | test/unittests/wasm/module-decoder-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698