Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2492563002: Continue IFWL cleanup (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Continue IFWL cleanup Cleaning up more IFWL classes. Committed: https://pdfium.googlesource.com/pdfium/+/d2bf06228d7572545717cd36ea0dabc67e9b6d84

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -273 lines) Patch
M xfa/fwl/core/cfwl_combobox.h View 1 chunk +24 lines, -24 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 3 chunks +33 lines, -45 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.h View 2 chunks +27 lines, -27 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.cpp View 4 chunks +43 lines, -60 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_combolist.cpp View 4 chunks +12 lines, -9 lines 0 comments Download
M xfa/fwl/core/ifwl_formproxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.h View 4 chunks +45 lines, -51 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.cpp View 1 5 chunks +14 lines, -16 lines 0 comments Download
M xfa/fwl/core/ifwl_picturebox.h View 2 chunks +1 line, -6 lines 0 comments Download
M xfa/fwl/core/ifwl_picturebox.cpp View 2 chunks +1 line, -19 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.h View 2 chunks +7 lines, -9 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-09 19:25:14 UTC) #4
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-09 21:15:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492563002/20001
4 years, 1 month ago (2016-11-10 20:08:09 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 20:46:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d2bf06228d7572545717cd36ea0dabc67e9b...

Powered by Google App Engine
This is Rietveld 408576698