Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 2482253004: Convert FWL_SCBCODE to an enum class (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Convert FWL_SCBCODE to an enum class This Cl changes the enum into an enum class and updates calling code to pass the enum instead of a uint32_t Committed: https://pdfium.googlesource.com/pdfium/+/3e577c2660c89646b56753839c1ec59c3ad187f4

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -64 lines) Patch
M xfa/fwl/core/cfwl_event.h View 2 chunks +14 lines, -1 line 0 comments Download
M xfa/fwl/core/ifwl_edit.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_edit.cpp View 1 2 1 chunk +11 lines, -12 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_listbox.cpp View 1 2 1 chunk +11 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.h View 1 2 3 chunks +2 lines, -15 lines 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.cpp View 4 chunks +12 lines, -24 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-09 17:20:19 UTC) #2
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-09 17:28:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482253004/40001
4 years, 1 month ago (2016-11-10 18:35:47 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 19:01:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/3e577c2660c89646b56753839c1ec59c3ad1...

Powered by Google App Engine
This is Rietveld 408576698