Implement aria-placeholder

Implement aria-placeholder

BUG=665611
Committed: https://crrev.com/5942181be68e28305ce40d64c5ba26854d9e3e3c
Cr-Commit-Position: refs/heads/master@{#435414}

[aboxhall, 2016-11-11 00:54:07]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 00:54:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 02:23:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 02:23:10]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aboxhall, 2016-11-15 17:50:58]

aboxhall@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-11-15 17:52:42]

Awesome! Add a bug / file one if not already there?

[dmazzoni, 2016-11-15 18:11:15]

Can you also implement what the CORE-AAM spec says too:
http://w3c.github.io/aria/core-aam/core-aam.html

Specifically, the placeholder should be exposed as
an IA2 attribute on Windows, something like:

StringAttributeToIA2(ui::AX_ATTR_PLACEHOLDER, "placeholder");

You can test for IA2 attributes in the Dump* tests easily,
see aria-posinset.html for an example.

https://codereview.chromium.org/2492083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2492083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:2934: if
(isHTMLInputElement(*getNode())) {
You can clean up this code slightly, use isHTMLTextFormControlElement and then
toHTMLTextFormControlElement, which is where strippedPlaceholder() is
implemented.

[dmazzoni, 2016-11-15 18:17:26]

Does the spec say we should include aria-placeholder in the
description calculation? I only see it in the name calc but maybe
I misread it.

I think we shouldn't expose the placeholder IA2 attribute or
the Mac AXPlaceholder attribute if the placeholder is used in
the name or description calculation. I think the code should
already do that, but it'd be good to test that.

So how I interpret it is that, on Mac for example:

<input aria-placeholder="mm-dd-yy">
AXDescription="mm-dd-yy"
AXPlaceholder=null

<input aria-label="Date" aria-placeholder="mm-dd-yy">
AXDescription="Date"
AXPlaceholder="mm-dd-yy"

<input aria-label="Date" title="Today" aria-placeholder="mm-dd-yy">
AXDescription="Date"
AXHelp="Today"
AXPlaceholder="mm-dd-yy"

And similarly on Windows.

[aboxhall, 2016-11-16 00:53:14]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[aboxhall, 2016-11-16 00:53:24]

The CQ bit was unchecked by aboxhall@chromium.org

[commit-bot: I haz the power, 2016-11-16 00:53:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aboxhall, 2016-11-16 00:58:03]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 00:58:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aboxhall, 2016-11-16 00:58:47]

On 2016/11/15 18:11:15, dmazzoni wrote:
> Can you also implement what the CORE-AAM spec says too:
> http://w3c.github.io/aria/core-aam/core-aam.html
> 
> Specifically, the placeholder should be exposed as
> an IA2 attribute on Windows, something like:
> 
> StringAttributeToIA2(ui::AX_ATTR_PLACEHOLDER, "placeholder");
> 
> You can test for IA2 attributes in the Dump* tests easily,
> see aria-posinset.html for an example.

Done, for Windows at least, I think.

https://codereview.chromium.org/2492083002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):
> 
>
https://codereview.chromium.org/2492083002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:2934: if
> (isHTMLInputElement(*getNode())) {
> You can clean up this code slightly, use isHTMLTextFormControlElement and then
> toHTMLTextFormControlElement, which is where strippedPlaceholder() is
> implemented.

Done.

[aboxhall, 2016-11-16 00:59:19]

On 2016/11/15 18:17:26, dmazzoni wrote:
> Does the spec say we should include aria-placeholder in the
> description calculation? I only see it in the name calc but maybe
> I misread it.
> 
> I think we shouldn't expose the placeholder IA2 attribute or
> the Mac AXPlaceholder attribute if the placeholder is used in
> the name or description calculation. I think the code should
> already do that, but it'd be good to test that.
> 
> So how I interpret it is that, on Mac for example:
> 
> <input aria-placeholder="mm-dd-yy">
> AXDescription="mm-dd-yy"
> AXPlaceholder=null
> 
> <input aria-label="Date" aria-placeholder="mm-dd-yy">
> AXDescription="Date"
> AXPlaceholder="mm-dd-yy"
> 
> <input aria-label="Date" title="Today" aria-placeholder="mm-dd-yy">
> AXDescription="Date"
> AXHelp="Today"
> AXPlaceholder="mm-dd-yy"
> 
> And similarly on Windows.

As discussed, instead never using placeholder or aria-placeholder for
description at all.

[commit-bot: I haz the power, 2016-11-16 01:13:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 01:13:16]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[dmazzoni, 2016-11-16 04:26:23]

lgtm now once tests pass, don't forget to add the bug number

https://codereview.chromium.org/2492083002/diff/60001/content/browser/accessi...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/2492083002/diff/60001/content/browser/accessi...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:1084:
RunHtmlTest(FILE_PATH_LITERAL("input-text-aria-placeholder.html"));
Nit: the ARIA tests are typically in the "aria" directory,
content/test/data/accessibility/aria - use RunAriaTest here instead

[aboxhall, 2016-11-16 18:18:41]

Patchset #5 (id:80001) has been deleted

[aboxhall, 2016-11-16 18:34:18]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[aboxhall, 2016-11-16 18:34:43]

Description was changed from

==========
Implement aria-placeholder

BUG=
==========

to

==========
Implement aria-placeholder

BUG=665611
==========

[commit-bot: I haz the power, 2016-11-16 18:34:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aboxhall, 2016-11-16 18:37:59]

The CQ bit was unchecked by aboxhall@chromium.org

[aboxhall, 2016-11-16 18:39:57]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 18:40:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 19:19:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 19:19:17]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[aboxhall, 2016-11-16 19:29:35]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 19:30:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 20:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 20:05:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aboxhall, 2016-11-16 22:41:14]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 22:41:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-11-16 23:34:35]

lgtm, looks like one Android test expectation is empty

https://codereview.chromium.org/2492083002/diff/180001/content/test/data/acce...
File content/test/data/accessibility/html/input-text-aria-placeholder.html
(right):

https://codereview.chromium.org/2492083002/diff/180001/content/test/data/acce...
content/test/data/accessibility/html/input-text-aria-placeholder.html:13: <input
type="text" aria-placeholder="aria-placeholder1" autofocus>
Maybe remove autofocus? It doesn't make sense on more than one anyway

[commit-bot: I haz the power, 2016-11-17 00:28:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 00:28:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[aboxhall, 2016-11-17 00:42:38]

Script didn't pick up the android expectation so I copied it in by hand. Fingers
crossed...

https://codereview.chromium.org/2492083002/diff/180001/content/test/data/acce...
File content/test/data/accessibility/html/input-text-aria-placeholder.html
(right):

https://codereview.chromium.org/2492083002/diff/180001/content/test/data/acce...
content/test/data/accessibility/html/input-text-aria-placeholder.html:13: <input
type="text" aria-placeholder="aria-placeholder1" autofocus>
On 2016/11/16 23:34:34, dmazzoni wrote:
> Maybe remove autofocus? It doesn't make sense on more than one anyway

Done.

[aboxhall, 2016-11-17 00:42:52]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2016-11-17 00:42:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2492083002/#ps200001
(title: "Remove autofocus, add expectation
")

[aboxhall, 2016-11-17 00:43:26]

The CQ bit was unchecked by aboxhall@chromium.org

[aboxhall, 2016-11-17 00:53:27]

https://codereview.chromium.org/2492083002/diff/60001/content/browser/accessi...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/2492083002/diff/60001/content/browser/accessi...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:1084:
RunHtmlTest(FILE_PATH_LITERAL("input-text-aria-placeholder.html"));
On 2016/11/16 04:26:23, dmazzoni wrote:
> Nit: the ARIA tests are typically in the "aria" directory,
> content/test/data/accessibility/aria - use RunAriaTest here instead

Done.

[aboxhall, 2016-11-17 00:53:35]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2016-11-17 00:53:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2492083002/#ps220001
(title: "Move to aria test")

[commit-bot: I haz the power, 2016-11-17 00:54:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 02:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 02:26:25]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aboxhall, 2016-11-18 00:19:31]

aboxhall@chromium.org changed reviewers:
+ pdr@chromium.org

[aboxhall, 2016-11-18 00:19:34]

aboxhall@chromium.org changed reviewers:
+ pdr@chromium.org

[aboxhall, 2016-11-18 00:19:34]

+pdr for OWNERS review of HTMLAttributeNames.in and {Source,public}/web/

[aboxhall, 2016-11-18 00:19:35]

+pdr for OWNERS review of HTMLAttributeNames.in and {Source,public}/web/

[pdr., 2016-11-18 01:09:27]

On 2016/11/18 at 00:19:35, aboxhall wrote:
> +pdr for OWNERS review of HTMLAttributeNames.in and {Source,public}/web/

LGTM

[aboxhall, 2016-11-18 02:21:50]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:23:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 02:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:36:34]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[aboxhall, 2016-11-18 17:18:27]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2016-11-18 17:19:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 17:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 17:24:05]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aboxhall, 2016-11-18 23:19:05]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2016-11-18 23:19:05]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2492083002/#ps260001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-18 23:19:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 00:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 00:53:47]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[aboxhall, 2016-11-29 19:08:48]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2016-11-29 19:09:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 21:44:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 21:44:51]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[aboxhall, 2016-11-30 00:49:02]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2016-11-30 00:49:03]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2492083002/#ps280001
(title: "Rebaseline android placeholder test")

[commit-bot: I haz the power, 2016-11-30 00:49:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 02:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 02:52:08]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[aboxhall, 2016-11-30 19:50:04]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2016-11-30 19:50:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 21:08:00]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1480535404506920,
"parent_rev": "eac664e1549c41a707ff16375c3fc98eebfb73cd", "commit_rev":
"b2256f86a7aeaa33b84b5ebe7c018999205891cc"}

[commit-bot: I haz the power, 2016-11-30 21:08:32]

Description was changed from

==========
Implement aria-placeholder

BUG=665611
==========

to

==========
Implement aria-placeholder

BUG=665611
==========

[commit-bot: I haz the power, 2016-11-30 21:08:36]

Committed patchset #14 (id:280001)

[commit-bot: I haz the power, 2016-11-30 21:12:37]

Description was changed from

==========
Implement aria-placeholder

BUG=665611
==========

to

==========
Implement aria-placeholder

BUG=665611

Committed: https://crrev.com/5942181be68e28305ce40d64c5ba26854d9e3e3c
Cr-Commit-Position: refs/heads/master@{#435414}
==========

[commit-bot: I haz the power, 2016-11-30 21:12:39]

Patchset 14 (id:??) landed as
https://crrev.com/5942181be68e28305ce40d64c5ba26854d9e3e3c
Cr-Commit-Position: refs/heads/master@{#435414}