Implement aria-placeholder

third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 2351 matching lines @@
   }
 
   // 5.1 Text inputs - step 3 (placeholder attribute)
   if (htmlElement && htmlElement->isTextFormControl()) {
     nameFrom = AXNameFromPlaceholder;
     if (nameSources) {
       nameSources->append(NameSource(*foundTextAlternative, placeholderAttr));
       NameSource& source = nameSources->last();
       source.type = nameFrom;
     }
-    HTMLElement* element = toHTMLElement(getNode());
-    const AtomicString& placeholder =
-        element->fastGetAttribute(placeholderAttr);
+    const String placeholder = placeholderFromAttribute();
     if (!placeholder.isEmpty()) {
       textAlternative = placeholder;
       if (nameSources) {
         NameSource& source = nameSources->last();
         source.text = textAlternative;
-        source.attributeValue = placeholder;
+        source.attributeValue = htmlElement->fastGetAttribute(placeholderAttr);
+        *foundTextAlternative = true;
       } else {
         return textAlternative;
       }
     }
+
+    // Also check for aria-placeholder.
+    nameFrom = AXNameFromPlaceholder;
+    if (nameSources) {
+      nameSources->append(
+          NameSource(*foundTextAlternative, aria_placeholderAttr));
+      NameSource& source = nameSources->last();
+      source.type = nameFrom;
+    }
+    const AtomicString& ariaPlaceholder =
+        htmlElement->fastGetAttribute(aria_placeholderAttr);
+    if (!ariaPlaceholder.isEmpty()) {
+      textAlternative = ariaPlaceholder;
+      if (nameSources) {
+        NameSource& source = nameSources->last();
+        source.text = textAlternative;
+        source.attributeValue = ariaPlaceholder;
+        *foundTextAlternative = true;
+      } else {
+        return textAlternative;
+      }
+    }
+
     return textAlternative;
   }
 
   // 5.7 figure and figcaption Elements
   if (getNode()->hasTagName(figureTag)) {
     // figcaption
     nameFrom = AXNameFromRelatedElement;
     if (nameSources) {
       nameSources->append(NameSource(*foundTextAlternative));
       nameSources->last().type = nameFrom;
@@ skipping 314 matching lines @@
   // http://rawgit.com/w3c/aria/master/html-aam/html-aam.html
   if (nameFrom != AXNameFromPlaceholder && htmlElement &&
       htmlElement->isTextFormControl()) {
     descriptionFrom = AXDescriptionFromPlaceholder;
     if (descriptionSources) {
       descriptionSources->append(
           DescriptionSource(foundDescription, placeholderAttr));
       DescriptionSource& source = descriptionSources->last();
       source.type = descriptionFrom;
     }
-    HTMLElement* element = toHTMLElement(getNode());
-    const AtomicString& placeholder =
-        element->fastGetAttribute(placeholderAttr);
+    const String placeholder = placeholderFromAttribute();
     if (!placeholder.isEmpty()) {
-      description = placeholder;
+      description = AtomicString(placeholder);
       if (descriptionSources) {
         DescriptionSource& source = descriptionSources->last();
         source.text = description;
-        source.attributeValue = placeholder;
+        source.attributeValue = htmlElement->fastGetAttribute(placeholderAttr);
         foundDescription = true;
       } else {
         return description;
+      }
+    }
+
+    // Also check for aria-placeholder.
+    descriptionFrom = AXDescriptionFromPlaceholder;
+    if (descriptionSources) {
+      descriptionSources->append(
+          DescriptionSource(foundDescription, aria_placeholderAttr));
+      DescriptionSource& source = descriptionSources->last();
+      source.type = descriptionFrom;
+    }
+    const AtomicString& ariaPlaceholder =
+        htmlElement->fastGetAttribute(aria_placeholderAttr);
+    if (!ariaPlaceholder.isEmpty()) {
+      description = ariaPlaceholder;
+      if (descriptionSources) {
+        DescriptionSource& source = descriptionSources->last();
+        source.text = description;
+        source.attributeValue = ariaPlaceholder;
+        foundDescription = true;
+      } else {
+        return description;
       }
     }
   }
 
   const HTMLInputElement* inputElement = nullptr;
   if (isHTMLInputElement(getNode()))
     inputElement = toHTMLInputElement(getNode());
 
   // value, 5.2.2 from: http://rawgit.com/w3c/aria/master/html-aam/html-aam.html
   if (nameFrom != AXNameFromValue && inputElement &&
@@ skipping 137 matching lines @@
                                  AXDescriptionFrom descriptionFrom) const {
   if (nameFrom == AXNameFromPlaceholder)
     return String();
 
   if (descriptionFrom == AXDescriptionFromPlaceholder)
     return String();
 
   if (!getNode())
     return String();
 
-  String placeholder;
+  return placeholderFromAttribute();
+}
+
+String AXNodeObject::placeholderFromAttribute() const {
   if (isHTMLInputElement(*getNode())) {

[dmazzoni, 2016/11/15 18:11:15]

You can clean up this code slightly, use isHTMLTextFormControlElement and then
toHTMLTextFormControlElement, which is where strippedPlaceholder() is
implemented.

     HTMLInputElement* inputElement = toHTMLInputElement(getNode());
-    placeholder = inputElement->strippedPlaceholder();
+    return inputElement->strippedPlaceholder();
   } else if (isHTMLTextAreaElement(*getNode())) {
     HTMLTextAreaElement* textAreaElement = toHTMLTextAreaElement(getNode());
-    placeholder = textAreaElement->strippedPlaceholder();
+    return textAreaElement->strippedPlaceholder();
   }
-  return placeholder;
+  return String();
 }
 
 DEFINE_TRACE(AXNodeObject) {
   visitor->trace(m_node);
   AXObject::trace(visitor);
 }
 
 }  // namespace blink