content/renderer/accessibility/blink_ax_tree_source.cc - Issue 2492083002: Implement aria-placeholder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 2492083002: Implement aria-placeholder (Closed)

Patch Set: Rebaseline android placeholder test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index f97a7548cd0737fcbb6b4ea079e5c8393d5ed751..3585666586d2914f34aec4af1364bc2f18c0a565 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -342,7 +342,7 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

ui::AX_ATTR_DESCRIBEDBY_IDS, descriptionObjects, dst);

}

- blink::WebString web_placeholder = src.placeholder(nameFrom, descriptionFrom);

+ blink::WebString web_placeholder = src.placeholder(nameFrom);

if (!web_placeholder.isEmpty())

dst->AddStringAttribute(ui::AX_ATTR_PLACEHOLDER, web_placeholder.utf8());