Mojo C++ bindings: switch device/serial mojom target to use STL types.

Mojo C++ bindings: switch device/serial mojom target to use STL types.

BUG=624136
TBR=scottmg@chromium for trivial change in tools/

Committed: https://crrev.com/cb096b31e1fa729b0e106f6d07777bade6aad9bc
Cr-Commit-Position: refs/heads/master@{#431970}

[yzshen1, 2016-11-11 20:48:45]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 20:49:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-11-11 20:51:15]

Description was changed from

==========
Mojo C++ bindings: switch device/serial mojom target to use STL types.

BUG=624136
==========

to

==========
Mojo C++ bindings: switch device/serial mojom target to use STL types.

BUG=624136
TBR=scottmg@chromium for trivial change in tools/
==========

[yzshen1, 2016-11-11 20:51:15]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2016-11-11 20:51:33]

Hi, Ken.

Would you please take a look? Thanks!

[commit-bot: I haz the power, 2016-11-11 21:16:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 21:16:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yzshen1, 2016-11-11 21:42:48]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 21:43:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 22:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 22:46:40]

Dry run: This issue passed the CQ dry run.

[scottmg, 2016-11-14 17:22:48]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-11-14 17:22:49]

tools rs lgtm

https://codereview.chromium.org/2492013005/diff/20001/tools/battor_agent/batt...
File tools/battor_agent/battor_finder.cc (right):

https://codereview.chromium.org/2492013005/diff/20001/tools/battor_agent/batt...
tools/battor_agent/battor_finder.cc:43: auto& display_name =
devices[i]->display_name.value();
Sorry, I couldn't figure out what type display_name is now. It's a nullable
wrapper around std::string?

Maybe the auto& could be const auto&.

[yzshen1, 2016-11-14 17:27:55]

Thanks Scott!

https://codereview.chromium.org/2492013005/diff/20001/tools/battor_agent/batt...
File tools/battor_agent/battor_finder.cc (right):

https://codereview.chromium.org/2492013005/diff/20001/tools/battor_agent/batt...
tools/battor_agent/battor_finder.cc:43: auto& display_name =
devices[i]->display_name.value();
On 2016/11/14 17:22:48, scottmg (ooo nov11) wrote:
> Sorry, I couldn't figure out what type display_name is now. It's a nullable
> wrapper around std::string?
> 
> Maybe the auto& could be const auto&.

Its type is now base::Optional<std::string>. 

Changed to "const auto&".

Thanks!

[Ken Rockot(use gerrit already), 2016-11-14 18:09:50]

lgtm

[yzshen1, 2016-11-14 18:28:26]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-11-14 18:28:26]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2492013005/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-11-14 18:28:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 19:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:36:35]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yzshen1, 2016-11-14 20:01:01]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-11-14 20:02:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 23:37:10]

Failed to apply patch for device/serial/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: device/serial/BUILD.gn:89
  error: device/serial/BUILD.gn: patch does not apply

Patch:       device/serial/BUILD.gn
Index: device/serial/BUILD.gn
diff --git a/device/serial/BUILD.gn b/device/serial/BUILD.gn
index
3fd7eb55f4de70cea20a15da73163d98842999f9..2881619c67784948ed46068f05d9c8b26dd78341
100644
--- a/device/serial/BUILD.gn
+++ b/device/serial/BUILD.gn
@@ -89,6 +89,4 @@ mojom("serial_mojo") {
   sources = [
     "serial.mojom",
   ]
-
-  use_new_wrapper_types = false
 }

[yzshen1, 2016-11-14 23:41:07]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-11-14 23:41:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2492013005/#ps60001
(title: "\")

[commit-bot: I haz the power, 2016-11-14 23:42:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:43:37]

Description was changed from

==========
Mojo C++ bindings: switch device/serial mojom target to use STL types.

BUG=624136
TBR=scottmg@chromium for trivial change in tools/
==========

to

==========
Mojo C++ bindings: switch device/serial mojom target to use STL types.

BUG=624136
TBR=scottmg@chromium for trivial change in tools/

Committed: https://crrev.com/cb096b31e1fa729b0e106f6d07777bade6aad9bc
Cr-Commit-Position: refs/heads/master@{#431970}
==========

[commit-bot: I haz the power, 2016-11-14 23:43:38]

Patchset 4 (id:??) landed as
https://crrev.com/cb096b31e1fa729b0e106f6d07777bade6aad9bc
Cr-Commit-Position: refs/heads/master@{#431970}