Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2492013005: Mojo C++ bindings: switch device/serial mojom target to use STL types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch device/serial mojom target to use STL types. BUG=624136 TBR=scottmg@chromium for trivial change in tools/ Committed: https://crrev.com/cb096b31e1fa729b0e106f6d07777bade6aad9bc Cr-Commit-Position: refs/heads/master@{#431970}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : \ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M device/serial/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/serial/serial_device_enumerator_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_device_enumerator_mac.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_device_enumerator_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/serial/serial_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/battor_agent/battor_finder.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 29 (19 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-11 20:51:33 UTC) #5
scottmg
tools rs lgtm https://codereview.chromium.org/2492013005/diff/20001/tools/battor_agent/battor_finder.cc File tools/battor_agent/battor_finder.cc (right): https://codereview.chromium.org/2492013005/diff/20001/tools/battor_agent/battor_finder.cc#newcode43 tools/battor_agent/battor_finder.cc:43: auto& display_name = devices[i]->display_name.value(); Sorry, I ...
4 years, 1 month ago (2016-11-14 17:22:49 UTC) #13
yzshen1
Thanks Scott! https://codereview.chromium.org/2492013005/diff/20001/tools/battor_agent/battor_finder.cc File tools/battor_agent/battor_finder.cc (right): https://codereview.chromium.org/2492013005/diff/20001/tools/battor_agent/battor_finder.cc#newcode43 tools/battor_agent/battor_finder.cc:43: auto& display_name = devices[i]->display_name.value(); On 2016/11/14 17:22:48, ...
4 years, 1 month ago (2016-11-14 17:27:55 UTC) #14
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-11-14 18:09:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492013005/40001
4 years, 1 month ago (2016-11-14 18:28:59 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/67028)
4 years, 1 month ago (2016-11-14 19:36:35 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492013005/40001
4 years, 1 month ago (2016-11-14 20:02:16 UTC) #22
commit-bot: I haz the power
Failed to apply patch for device/serial/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
4 years, 1 month ago (2016-11-14 23:37:10 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492013005/60001
4 years, 1 month ago (2016-11-14 23:42:02 UTC) #27
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 23:43:38 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cb096b31e1fa729b0e106f6d07777bade6aad9bc
Cr-Commit-Position: refs/heads/master@{#431970}

Powered by Google App Engine
This is Rietveld 408576698