device/serial/serial_device_enumerator_win.cc - Issue 2492013005: Mojo C++ bindings: switch device/serial mojom target to use STL types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/serial_device_enumerator_win.cc

Issue 2492013005: Mojo C++ bindings: switch device/serial mojom target to use STL types. (Closed)

Patch Set: \ Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/serial/serial_device_enumerator_win.cc

diff --git a/device/serial/serial_device_enumerator_win.cc b/device/serial/serial_device_enumerator_win.cc

index 24d1ed7d32bf7bb3a5d6ab9f709bb7ffc6106bfa..149331d96c483551066e51190c4a15d5728905c3 100644

--- a/device/serial/serial_device_enumerator_win.cc

+++ b/device/serial/serial_device_enumerator_win.cc

@@ -113,7 +113,7 @@ mojo::Array<serial::DeviceInfoPtr> GetDevicesNew() {

std::string display_name;

if (GetDisplayName(friendly_name, &display_name))

- info->display_name = display_name;

+ info->display_name = std::move(display_name);

std::string hardware_id;

// SPDRP_HARDWAREID looks like "FTDIBUS\COMPORT&VID_0403&PID_6001".