extensions/browser/api/serial/serial_api.cc - Issue 2492013005: Mojo C++ bindings: switch device/serial mojom target to use STL types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_api.cc

Issue 2492013005: Mojo C++ bindings: switch device/serial mojom target to use STL types. (Closed)

Patch Set: \ Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/serial/serial_api.cc

diff --git a/extensions/browser/api/serial/serial_api.cc b/extensions/browser/api/serial/serial_api.cc

index 2dfc1b664da3aebac91aff177b98294c671ed312..6ef93a77a0c2c688416e04d721d4dc4c7ce8d6ad 100644

--- a/extensions/browser/api/serial/serial_api.cc

+++ b/extensions/browser/api/serial/serial_api.cc

@@ -488,7 +488,7 @@ extensions::api::serial::DeviceInfo TypeConverter<

if (device->has_product_id)

info.product_id.reset(new int(static_cast<int>(device->product_id)));

if (device->display_name)

- info.display_name.reset(new std::string(device->display_name));

+ info.display_name.reset(new std::string(device->display_name.value()));

return info;

}

« no previous file with comments | « device/serial/serial_device_enumerator_win.cc ('k') | tools/battor_agent/battor_finder.cc » ('j') | no next file with comments »