Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html

Issue 2491983002: [DevTools] reworked JavaScriptBreakpointsSidebarPane.js (Closed)
Patch Set: addressed offline comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html
index ca8ad0aa6165c1a7512fe009b3a155c86a1bd7b5..38caaadcafadaec033d7dc3e1a6243d94e649bb1 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html
@@ -54,14 +54,14 @@ var test = function()
expectedBreakpointLocations.filter((location) => (location[0] != line && location[1] != column));
if (expectedBreakpointLocations.length)
return;
- breakpointSourcesReceived = true;
+ breakpointSourcesReceived--;
maybeCompleteTest();
}
}
}
- var breakpointSourcesReceived = false;
+ var breakpointSourcesReceived = 2;
var pageReloaded = false;
function onPageReloaded()
@@ -72,7 +72,7 @@ var test = function()
function maybeCompleteTest()
{
- if (!pageReloaded || !breakpointSourcesReceived)
+ if (!pageReloaded || !breakpointSourcesReceived <= 0)
return;
InspectorTest.dumpBreakpointSidebarPane("Breakpoints after reload:");
InspectorTest.completeDebuggerTest();

Powered by Google App Engine
This is Rietveld 408576698