third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/disable-breakpoints.html - Issue 2491983002: [DevTools] reworked JavaScriptBreakpointsSidebarPane.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/disable-breakpoints.html

Issue 2491983002: [DevTools] reworked JavaScriptBreakpointsSidebarPane.js (Closed)

Patch Set: addressed offline comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/set-conditional-breakpoint.html » ('j') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/disable-breakpoints.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/disable-breakpoints.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/disable-breakpoints.html

index bb0b5d5da94d369f1c80387939931edfaae4ecbd..c7da0c9580eba488447ccdca6418c4624ebde13d 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/disable-breakpoints.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/disable-breakpoints.html

@@ -92,11 +92,11 @@ var test = function()

{

InspectorTest.addResult("Test function finished.");

InspectorTest.dumpBreakpointSidebarPane();

- InspectorTest.addSniffer(currentSourceFrame, "_removeBreakpointDecoration", breakpointRemoved);

+ InspectorTest.addSniffer(WebInspector.JavaScriptBreakpointsSidebarPane.prototype, "didUpdateForTest", dumpBreakpointSidebarPane.bind(this));

InspectorTest.removeBreakpoint(currentSourceFrame, 7);

}

- function breakpointRemoved()

+ function dumpBreakpointSidebarPane()

{

InspectorTest.addResult("Breakpoints removed.");

InspectorTest.dumpBreakpointSidebarPane();