Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html

Issue 2491983002: [DevTools] reworked JavaScriptBreakpointsSidebarPane.js (Closed)
Patch Set: addressed offline comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html b/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
index 5ca9eccb3dc91cea462710f230dd5d7ee7a200f9..32f5693dba59595ff201b473378b967076e1cbdd 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
@@ -28,8 +28,7 @@ function test()
function onSourceFrame(sourceFrame)
{
InspectorTest.setBreakpoint(sourceFrame, 0, "", true);
- dumpBreakpointSidebarPane();
- next();
+ InspectorTest.addSniffer(WebInspector.JavaScriptBreakpointsSidebarPane.prototype, "_breakpointsWasUpdatedForTest", dumpBreakpointSidebarPane.bind(this, next));
}
},
@@ -40,8 +39,7 @@ function test()
function onBindingCreated(binding)
{
- dumpBreakpointSidebarPane();
- next();
+ InspectorTest.addSniffer(WebInspector.JavaScriptBreakpointsSidebarPane.prototype, "_breakpointsWasUpdatedForTest", dumpBreakpointSidebarPane.bind(this, next));
}
},
@@ -56,18 +54,20 @@ function test()
if (binding.network.name() !== "foo.js")
return
WebInspector.persistence.removeEventListener(WebInspector.Persistence.Events.BindingRemoved, onBindingRemoved);
- dumpBreakpointSidebarPane();
- next();
+ InspectorTest.addSniffer(WebInspector.JavaScriptBreakpointsSidebarPane.prototype, "_breakpointsWasUpdatedForTest", dumpBreakpointSidebarPane.bind(this, next));
}
},
]);
- function dumpBreakpointSidebarPane()
+ function dumpBreakpointSidebarPane(next)
{
var sidebarPane = self.runtime.sharedInstance(WebInspector.JavaScriptBreakpointsSidebarPane)
- var breakpoints = sidebarPane._items.keysArray();
- for (var breakpoint of breakpoints)
- InspectorTest.addResult(" " + breakpoint.uiSourceCode().url() +":" + breakpoint.lineNumber());
+ var uiSourceCodes = sidebarPane._items.keysArray();
+ for (var uiSourceCode of uiSourceCodes) {
+ for (var lineNumber of sidebarPane._items.get(uiSourceCode).keysArray())
+ InspectorTest.addResult(" " + uiSourceCode.url() +":" + lineNumber);
+ }
+ next();
}
};
</script>

Powered by Google App Engine
This is Rietveld 408576698