third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html - Issue 2491983002: [DevTools] reworked JavaScriptBreakpointsSidebarPane.js

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html

Issue 2491983002: [DevTools] reworked JavaScriptBreakpointsSidebarPane.js (Closed)

Patch Set: addressed offline comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html » ('j') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../inspector-test.js"></script>	3 <script src="../inspector-test.js"></script>

4 <script src="../debugger-test.js"></script>	4 <script src="../debugger-test.js"></script>

5 <script src="../workspace-test.js"></script>	5 <script src="../workspace-test.js"></script>

6 <script src="../isolated-filesystem-test.js"></script>	6 <script src="../isolated-filesystem-test.js"></script>

7 <script src="./persistence-test.js"></script>	7 <script src="./persistence-test.js"></script>

8 <script src="./resources/foo.js"></script>	8 <script src="./resources/foo.js"></script>

9 <script>	9 <script>

10	10

(...skipping 10 matching lines...) Expand all Loading...
21	21

22 function setBreakpointInFileSystemUISourceCode(next)	22 function setBreakpointInFileSystemUISourceCode(next)

23 {	23 {

24 InspectorTest.waitForUISourceCode("foo.js", WebInspector.projectType s.FileSystem)	24 InspectorTest.waitForUISourceCode("foo.js", WebInspector.projectType s.FileSystem)

25 .then(code => InspectorTest.showUISourceCodePromise(code))	25 .then(code => InspectorTest.showUISourceCodePromise(code))

26 .then(onSourceFrame);	26 .then(onSourceFrame);

27	27

28 function onSourceFrame(sourceFrame)	28 function onSourceFrame(sourceFrame)

29 {	29 {

30 InspectorTest.setBreakpoint(sourceFrame, 0, "", true);	30 InspectorTest.setBreakpoint(sourceFrame, 0, "", true);

31 dumpBreakpointSidebarPane();	31 InspectorTest.addSniffer(WebInspector.JavaScriptBreakpointsSideb arPane.prototype, "_breakpointsWasUpdatedForTest", dumpBreakpointSidebarPane.bin d(this, next));

32 next();

33 }	32 }

34 },	33 },

35	34

36 function addFileMapping(next)	35 function addFileMapping(next)

37 {	36 {

38 InspectorTest.waitForBinding("foo.js").then(onBindingCreated);	37 InspectorTest.waitForBinding("foo.js").then(onBindingCreated);

39 WebInspector.fileSystemMapping.addFileMapping(fs.fileSystemPath, "ht tp://127.0.0.1:8000", "/");	38 WebInspector.fileSystemMapping.addFileMapping(fs.fileSystemPath, "ht tp://127.0.0.1:8000", "/");

40	39

41 function onBindingCreated(binding)	40 function onBindingCreated(binding)

42 {	41 {

43 dumpBreakpointSidebarPane();	42 InspectorTest.addSniffer(WebInspector.JavaScriptBreakpointsSideb arPane.prototype, "_breakpointsWasUpdatedForTest", dumpBreakpointSidebarPane.bin d(this, next));

44 next();

45 }	43 }

46 },	44 },

47	45

48 function removeFileMapping(next)	46 function removeFileMapping(next)

49 {	47 {

50 WebInspector.persistence.addEventListener(WebInspector.Persistence.E vents.BindingRemoved, onBindingRemoved);	48 WebInspector.persistence.addEventListener(WebInspector.Persistence.E vents.BindingRemoved, onBindingRemoved);

51 WebInspector.fileSystemMapping.removeFileMapping(fs.fileSystemPath, "http://127.0.0.1:8000", "/");	49 WebInspector.fileSystemMapping.removeFileMapping(fs.fileSystemPath, "http://127.0.0.1:8000", "/");

52	50

53 function onBindingRemoved(event)	51 function onBindingRemoved(event)

54 {	52 {

55 var binding = event.data;	53 var binding = event.data;

56 if (binding.network.name() !== "foo.js")	54 if (binding.network.name() !== "foo.js")

57 return	55 return

58 WebInspector.persistence.removeEventListener(WebInspector.Persis tence.Events.BindingRemoved, onBindingRemoved);	56 WebInspector.persistence.removeEventListener(WebInspector.Persis tence.Events.BindingRemoved, onBindingRemoved);

59 dumpBreakpointSidebarPane();	57 InspectorTest.addSniffer(WebInspector.JavaScriptBreakpointsSideb arPane.prototype, "_breakpointsWasUpdatedForTest", dumpBreakpointSidebarPane.bin d(this, next));

60 next();

61 }	58 }

62 },	59 },

63 ]);	60 ]);

64	61

65 function dumpBreakpointSidebarPane()	62 function dumpBreakpointSidebarPane(next)

66 {	63 {

67 var sidebarPane = self.runtime.sharedInstance(WebInspector.JavaScriptBre akpointsSidebarPane)	64 var sidebarPane = self.runtime.sharedInstance(WebInspector.JavaScriptBre akpointsSidebarPane)

68 var breakpoints = sidebarPane._items.keysArray();	65 var uiSourceCodes = sidebarPane._items.keysArray();

69 for (var breakpoint of breakpoints)	66 for (var uiSourceCode of uiSourceCodes) {

70 InspectorTest.addResult(" " + breakpoint.uiSourceCode().url() +": " + breakpoint.lineNumber());	67 for (var lineNumber of sidebarPane._items.get(uiSourceCode).keysArra y())

	68 InspectorTest.addResult(" " + uiSourceCode.url() +":" + lineN umber);

	69 }

	70 next();

71 }	71 }

72 };	72 };

73 </script>	73 </script>

74 </head>	74 </head>

75 <body onload="runTest()">	75 <body onload="runTest()">

76 <p>Verify that breakpoints are moved appropriately</p>	76 <p>Verify that breakpoints are moved appropriately</p>

77 </body>	77 </body>

78 </html>	78 </html>

OLD	NEW