Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 2491823003: Timeline: add experiment to show events from subframes in the frames of their own (Closed)

Created:
4 years, 1 month ago by caseq
Modified:
4 years, 1 month ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: add experiment to show events from subframes in the tracks of their own BUG=662990 Committed: https://crrev.com/2c0dc79b4e3b214f1e4accb8fc4d70ef191d78ba Cr-Commit-Position: refs/heads/master@{#431753}

Patch Set 1 : split & rebased #

Total comments: 1

Patch Set 2 : review comments addressed #

Patch Set 3 : Timeline: add experiment to show events from subframes in the frames of their own #

Patch Set 4 : rebased, adjusted name logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -17 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 2 3 2 chunks +24 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js View 1 2 3 12 chunks +50 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
caseq
4 years, 1 month ago (2016-11-11 01:24:08 UTC) #4
alph
lgtm https://codereview.chromium.org/2491823003/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/2491823003/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode438 third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:438: frame.children.forEach(child => this._appendFrameEvents(child, level + 1)); nit: if ...
4 years, 1 month ago (2016-11-11 02:32:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491823003/80001
4 years, 1 month ago (2016-11-12 01:11:54 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 1 month ago (2016-11-12 02:37:02 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 02:40:25 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2c0dc79b4e3b214f1e4accb8fc4d70ef191d78ba
Cr-Commit-Position: refs/heads/master@{#431753}

Powered by Google App Engine
This is Rietveld 408576698