third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js - Issue 2491823003: Timeline: add experiment to show events from subframes in the frames of their own

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2491823003: Timeline: add experiment to show events from subframes in the frames of their own (Closed)

Patch Set: rebased, adjusted name logic Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

index fed5808cf1773877d4102f0120e2270ada957fb2..1f30c9c6e08e07945b4bd8a417ac89470d3826fb 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

@@ -510,11 +510,7 @@ WebInspector.AggregatedTimelineTreeView = class extends WebInspector.TimelineTre

break;

case WebInspector.AggregatedTimelineTreeView.GroupBy.Frame:

var frame = this._model.pageFrameById(node.id);

- var frameName;

- if (frame && frame.url)

- frameName = frame.url.startsWith('about:') && frame.name ? `"${frame.name}"` : frame.url;

- else

- frameName = WebInspector.UIString('Page');

+ var frameName = frame ? WebInspector.TimelineUIUtils.displayNameForFrame(frame, 80) : WebInspector.UIString('Page');

return {

name: frameName,

color: color