third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js - Issue 2491823003: Timeline: add experiment to show events from subframes in the frames of their own

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2491823003: Timeline: add experiment to show events from subframes in the frames of their own (Closed)

Patch Set: rebased, adjusted name logic Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

index fc6b986635f0fa62aa5e5ab4ddf5c81ae8ddd7fc..7a233a49bf3b0144fb2638ca33d17e4a71ab2db7 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -1738,6 +1738,17 @@ WebInspector.TimelineUIUtils = class {

}

return span;

}

+ /**

+ * @param {!WebInspector.TimelineModel.PageFrame} frame

+ * @param {number=} trimAt

+ */

+ static displayNameForFrame(frame, trimAt) {

+ var url = frame.url;

+ if (!trimAt)

+ trimAt = 30;

+ return url.startsWith('about:') ? `"${frame.name.trimMiddle(trimAt)}"` : frame.url.trimEnd(trimAt);

+ }

};

/**