Issue 249103002: StringTable::LookupKey() and all callers handlified.

Issue 249103002: StringTable::LookupKey() and all callers handlified. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

StringTable::LookupKey() and all callers handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20915

Patch Set 2 : Addressing review notes #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -158 lines)			Patch
M	src/factory.h	View		3 chunks	+9 lines, -1 line	0 comments	Download
M	src/factory.cc	View		3 chunks	+24 lines, -11 lines	0 comments	Download
M	src/heap.h	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	src/heap.cc	View		3 chunks	+0 lines, -62 lines	0 comments	Download
M	src/mark-compact.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/objects.h	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/objects.cc	View		4 chunks	+34 lines, -38 lines	0 comments	Download
M	src/objects-inl.h	View		8 chunks	+19 lines, -14 lines	0 comments	Download
M	src/parser.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View		2 chunks	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc#newcode2150 src/mark-compact.cc:2150: // String table could have already been marked ...

6 years, 8 months ago (2014-04-23 15:17:46 UTC) #2

Igor Sheludko

Committed patchset #2 manually as r20915 (presubmit successful).

6 years, 8 months ago (2014-04-23 15:43:51 UTC) #3

Igor Sheludko

6 years, 8 months ago (2014-04-23 15:44:14 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc#newcode2150
src/mark-compact.cc:2150: // String table could have already been marked via
handle scope iteration.
On 2014/04/23 15:17:46, Yang wrote:
> I would rewrite the comment to "...been marked by visiting the handles list."

Done.

Expand Messages | Collapse Messages