test/cctest/test-api.cc - Issue 249103002: StringTable::LookupKey() and all callers handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 249103002: StringTable::LookupKey() and all callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing review notes Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index e90dd4e2677d53e9abb2e471734f7d977b09c245..5ea1c9e573711e7722f32c5e68ef949165d142a9 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -17994,7 +17994,8 @@ TEST(VisitExternalStrings) {

CcTest::heap()->CollectAllAvailableGarbage(); // Tenure string.

// Turn into a symbol.

i::Handle<i::String> string3_i = v8::Utils::OpenHandle(*string3);

- CHECK(!CcTest::heap()->InternalizeString(*string3_i)->IsFailure());

+ CHECK(!CcTest::i_isolate()->factory()->InternalizeString(

+ string3_i).is_null());

CHECK(string3_i->IsInternalizedString());

// We need to add usages for string* to avoid warnings in GCC 4.7

« no previous file with comments | « src/parser.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »