Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Side by Side Diff: src/parser.cc

Issue 249103002: StringTable::LookupKey() and all callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing review notes Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3824 matching lines...) Expand 10 before | Expand all | Expand 10 after
3835 } 3835 }
3836 3836
3837 3837
3838 bool RegExpParser::simple() { 3838 bool RegExpParser::simple() {
3839 return simple_; 3839 return simple_;
3840 } 3840 }
3841 3841
3842 3842
3843 RegExpTree* RegExpParser::ReportError(Vector<const char> message) { 3843 RegExpTree* RegExpParser::ReportError(Vector<const char> message) {
3844 failed_ = true; 3844 failed_ = true;
3845 *error_ = isolate()->factory()->NewStringFromAscii( 3845 *error_ = isolate()->factory()->NewStringFromAscii(message).ToHandleChecked();
3846 message, NOT_TENURED).ToHandleChecked();
3847 // Zip to the end to make sure the no more input is read. 3846 // Zip to the end to make sure the no more input is read.
3848 current_ = kEndMarker; 3847 current_ = kEndMarker;
3849 next_pos_ = in()->length(); 3848 next_pos_ = in()->length();
3850 return NULL; 3849 return NULL;
3851 } 3850 }
3852 3851
3853 3852
3854 // Pattern :: 3853 // Pattern ::
3855 // Disjunction 3854 // Disjunction
3856 RegExpTree* RegExpParser::ParsePattern() { 3855 RegExpTree* RegExpParser::ParsePattern() {
(...skipping 836 matching lines...) Expand 10 before | Expand all | Expand 10 after
4693 ASSERT(info()->isolate()->has_pending_exception()); 4692 ASSERT(info()->isolate()->has_pending_exception());
4694 } else { 4693 } else {
4695 result = ParseProgram(); 4694 result = ParseProgram();
4696 } 4695 }
4697 } 4696 }
4698 info()->SetFunction(result); 4697 info()->SetFunction(result);
4699 return (result != NULL); 4698 return (result != NULL);
4700 } 4699 }
4701 4700
4702 } } // namespace v8::internal 4701 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698