Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2489883006: Replace registration_id() with registrationId() (Closed)

Created:
4 years, 1 month ago by adithyas
Modified:
4 years, 1 month ago
Reviewers:
falken, johnme, nhiroki
CC:
awdf+watch_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, harkness+watch_chromium.org, horo+watch_chromium.org, jam, jbroman, johnme+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, mlamouri+watch-content_chromium.org, mlamouri+watch-notifications_chromium.org, nhiroki, Peter Beverloo, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace registration_id() with registrationId() - Follow up to http://crrev.com/2473483012 BUG=662134 Committed: https://crrev.com/af8916be3799b8cbb9f45992564e69ca53f23b85 Cr-Commit-Position: refs/heads/master@{#433249}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M content/child/notifications/notification_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/push_messaging/push_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/service_worker_dispatcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M content/renderer/push_messaging/push_messaging_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
adithyas
4 years, 1 month ago (2016-11-18 15:40:01 UTC) #8
nhiroki
LGTM
4 years, 1 month ago (2016-11-18 15:49:29 UTC) #9
adithyas
+johnme for notifications/push_messaging
4 years, 1 month ago (2016-11-18 16:11:02 UTC) #11
johnme
*/push_messaging/* lgtm
4 years, 1 month ago (2016-11-18 16:40:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489883006/20001
4 years, 1 month ago (2016-11-18 18:27:44 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 18:41:46 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/af8916be3799b8cbb9f45992564e69ca53f23b85 Cr-Commit-Position: refs/heads/master@{#433249}
4 years, 1 month ago (2016-11-18 18:43:46 UTC) #19
falken
4 years, 1 month ago (2016-11-21 06:24:04 UTC) #20
Message was sent while issue was closed.
lgtm. thanks for this followup.

Powered by Google App Engine
This is Rietveld 408576698